You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/11/18 09:57:28 UTC

[GitHub] [airflow] ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports
URL: https://github.com/apache/airflow/pull/6596#discussion_r347282260
 
 

 ##########
 File path: airflow/executors/__init__.py
 ##########
 @@ -57,31 +56,25 @@ def get_default_executor():
     return DEFAULT_EXECUTOR
 
 
-class Executors:
 
 Review comment:
   I'm not immediately seeing why we need to pull this out of this file -- I think it was okay as it was?
   
   (I'm not a huge fan of one-file-per class, espeicaly for small classes)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services