You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Ben Craig (JIRA)" <ji...@apache.org> on 2015/05/06 15:20:00 UTC
[jira] [Closed] (THRIFT-2150) Should windows/config.h define
WIN32_LEAN_AND_MEAN?
[ https://issues.apache.org/jira/browse/THRIFT-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ben Craig closed THRIFT-2150.
-----------------------------
Resolution: Won't Fix
This is a Microsoft build infrastructure issue that is external to the project with plenty of help references readily available on how to resolve it in the including code.
> Should windows/config.h define WIN32_LEAN_AND_MEAN?
> ---------------------------------------------------
>
> Key: THRIFT-2150
> URL: https://issues.apache.org/jira/browse/THRIFT-2150
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.9.1
> Environment: MSVC
> Reporter: Chris Stylianou
> Assignee: James E. King, III
> Labels: c++, msvc, thrift, windows
>
> As "windows/config.h" includes Winsock2.h, is it not best practise to define before it:
> {code}WIN32_LEAN_AND_MEAN{code}
> This is in case someone includes Windows.h, which automatically includes the incompatible Winsock.h. It also reduces the size of the Win32 header files which helps compilation speeds :)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)