You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "sz-p (via GitHub)" <gi...@apache.org> on 2024/11/14 12:18:46 UTC
[PR] fix(graph): zooming a Force Graph with layoutAnimation false breaks edges [echarts]
sz-p opened a new pull request, #20517:
URL: https://github.com/apache/echarts/pull/20517
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
<!-- USE ONE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
### Fixed issues
#20515
## Details
### Before: What was the problem?
<!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
### After: How does it behave after the fixing?
<!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
## Document Info
One of the following should be checked.
- [x] This PR doesn't relate to document changes
- [ ] The document should be updated later
- [ ] The document changes have been made in apache/echarts-doc#xxx
## Misc
### ZRender Changes
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
N.A.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merging.
### Other information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix(graph): zooming a Force Graph with layoutAnimation false breaks edges [echarts]
Posted by "sz-p (via GitHub)" <gi...@apache.org>.
sz-p commented on PR #20517:
URL: https://github.com/apache/echarts/pull/20517#issuecomment-2476224634
I discovered the issue is in https://github.com/apache/echarts/blob/master/src/chart/graph/GraphView.ts#L281
it just update the `links` not both `nodes` and `links`.
It will be fixed when remove the update or update both `nodes` and `links`.
I'm not sure the update is necessary？
I have removed this update and It look work will.
If update both `nodes` and `links` the graph will have a large layout change when zoom hanpens
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix(graph): zooming a Force Graph with layoutAnimation false breaks edges [echarts]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20517:
URL: https://github.com/apache/echarts/pull/20517#issuecomment-4037011204
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20517@4b07cd3
<!-- ECHARTS_PR_PREVIEW -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix(graph): zooming a Force Graph with layoutAnimation false breaks edges [echarts]
Posted by "echarts-bot[bot] (via GitHub)" <gi...@apache.org>.
echarts-bot[bot] commented on PR #20517:
URL: https://github.com/apache/echarts/pull/20517#issuecomment-2476212952
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix(graph): zooming a Force Graph with layoutAnimation false breaks edges [echarts]
Posted by "sz-p (via GitHub)" <gi...@apache.org>.
sz-p commented on PR #20517:
URL: https://github.com/apache/echarts/pull/20517#issuecomment-4037006384
Conflicts resolved.
Can you help me review it @100pah (I noticed that you changed the `GraphView.ts` file) ^-^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org