You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by sa...@apache.org on 2016/11/14 07:52:36 UTC
spark git commit: [SPARK-18382][WEBUI] "run at null:-1" in UI when no
file/line info in call site info
Repository: spark
Updated Branches:
refs/heads/master 07be232ea -> f95b124c6
[SPARK-18382][WEBUI] "run at null:-1" in UI when no file/line info in call site info
## What changes were proposed in this pull request?
Avoid reporting null/-1 file / line number in call sites if encountering StackTraceElement without this info
## How was this patch tested?
Existing tests
Author: Sean Owen <so...@cloudera.com>
Closes #15862 from srowen/SPARK-18382.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/f95b124c
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/f95b124c
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/f95b124c
Branch: refs/heads/master
Commit: f95b124c68ccc2e318f6ac30685aa47770eea8f3
Parents: 07be232
Author: Sean Owen <so...@cloudera.com>
Authored: Mon Nov 14 16:52:07 2016 +0900
Committer: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Committed: Mon Nov 14 16:52:07 2016 +0900
----------------------------------------------------------------------
core/src/main/scala/org/apache/spark/util/Utils.scala | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/f95b124c/core/src/main/scala/org/apache/spark/util/Utils.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/org/apache/spark/util/Utils.scala b/core/src/main/scala/org/apache/spark/util/Utils.scala
index d341982..23b95b9 100644
--- a/core/src/main/scala/org/apache/spark/util/Utils.scala
+++ b/core/src/main/scala/org/apache/spark/util/Utils.scala
@@ -1419,8 +1419,12 @@ private[spark] object Utils extends Logging {
}
callStack(0) = ste.toString // Put last Spark method on top of the stack trace.
} else {
- firstUserLine = ste.getLineNumber
- firstUserFile = ste.getFileName
+ if (ste.getFileName != null) {
+ firstUserFile = ste.getFileName
+ if (ste.getLineNumber >= 0) {
+ firstUserLine = ste.getLineNumber
+ }
+ }
callStack += ste.toString
insideSpark = false
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org