You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm-dev@maven.apache.org by Eric Pugh <ep...@upstate.com> on 2004/01/18 19:34:01 UTC
Using pure Java implementation of CVS
Hi all,
JVZ dropped me a note about the progress on maven-scm and using the pure
Java CVS library in the generic-scm-providers/cvslib project. I'd be happy
to change the cvslib project to use the Java library that I used in the
ChangeLog plugin for Maven. I also have some refactoring ideas that would
make this a better implementation over what was used in ChangeLog.
I changed StreamPumperTest in the scm-api project to not use the deprecated
StringBufferInputStream class. However, it appears that I don't have karma
for committing to scm-api. I can send in my changes as patch files if you
would prefer.
Eric Pugh
RE: Using pure Java implementation of CVS
Posted by Eric Pugh <ep...@upstate.com>.
I am hoping to have everything ready by the end of this weekend to check in.
Thanks,
Eric
> -----Original Message-----
> From: Emmanuel Venisse [mailto:emmanuel@venisse.net]
> Sent: Friday, January 23, 2004 6:11 PM
> To: scm-dev@maven.apache.org
> Subject: Re: Using pure Java implementation of CVS
>
>
>
> ----- Original Message -----
> From: "Jason van Zyl" <jv...@maven.org>
> To: <sc...@maven.apache.org>
> Sent: Friday, January 23, 2004 5:59 PM
> Subject: Re: Using pure Java implementation of CVS
>
>
> > On Fri, 2004-01-23 at 11:42, Emmanuel Venisse wrote:
> >
> > > I think that Eric can be a maven-scm commiter.
> >
> > Just catching up now, but +1
> >
> > If the CVS stuff hasn't been taken care of I can do it.
> >
> > > Do you see that I add cvs tag command? You can test it
> with continuum.
> >
> > I definitely can.
> >
> > Did you track down the problem checking out large projects?
>
> For test, I rapidly try to remove all extra code (like output
> and error
> stream) but without success.
> I'll do more test the next week.
>
> >
> > --
> > jvz.
> >
> > Jason van Zyl
> > jason@maven.org
> > http://maven.apache.org
> >
> > First, the taking in of scattered particulars under one Idea,
> > so that everyone understands what is being talked about ... Second,
> > the separation of the Idea into parts, by dividing it at the joints,
> > as nature directs, not breaking any limb in half as a bad
> carver might.
> >
> > -- Plato, Phaedrus (Notes on the Synthesis of Form by C.
> Alexander)
> >
> >
Re: Using pure Java implementation of CVS
Posted by Emmanuel Venisse <em...@venisse.net>.
----- Original Message -----
From: "Jason van Zyl" <jv...@maven.org>
To: <sc...@maven.apache.org>
Sent: Friday, January 23, 2004 5:59 PM
Subject: Re: Using pure Java implementation of CVS
> On Fri, 2004-01-23 at 11:42, Emmanuel Venisse wrote:
>
> > I think that Eric can be a maven-scm commiter.
>
> Just catching up now, but +1
>
> If the CVS stuff hasn't been taken care of I can do it.
>
> > Do you see that I add cvs tag command? You can test it with continuum.
>
> I definitely can.
>
> Did you track down the problem checking out large projects?
For test, I rapidly try to remove all extra code (like output and error
stream) but without success.
I'll do more test the next week.
>
> --
> jvz.
>
> Jason van Zyl
> jason@maven.org
> http://maven.apache.org
>
> First, the taking in of scattered particulars under one Idea,
> so that everyone understands what is being talked about ... Second,
> the separation of the Idea into parts, by dividing it at the joints,
> as nature directs, not breaking any limb in half as a bad carver might.
>
> -- Plato, Phaedrus (Notes on the Synthesis of Form by C. Alexander)
>
>
Re: Using pure Java implementation of CVS
Posted by Jason van Zyl <jv...@maven.org>.
On Fri, 2004-01-23 at 11:42, Emmanuel Venisse wrote:
> I think that Eric can be a maven-scm commiter.
Just catching up now, but +1
If the CVS stuff hasn't been taken care of I can do it.
> Do you see that I add cvs tag command? You can test it with continuum.
I definitely can.
Did you track down the problem checking out large projects?
--
jvz.
Jason van Zyl
jason@maven.org
http://maven.apache.org
First, the taking in of scattered particulars under one Idea,
so that everyone understands what is being talked about ... Second,
the separation of the Idea into parts, by dividing it at the joints,
as nature directs, not breaking any limb in half as a bad carver might.
-- Plato, Phaedrus (Notes on the Synthesis of Form by C. Alexander)
Re: Using pure Java implementation of CVS
Posted by Emmanuel Venisse <em...@venisse.net>.
----- Original Message -----
From: "Jason van Zyl" <jv...@maven.org>
To: <sc...@maven.apache.org>
Sent: Friday, January 23, 2004 5:35 PM
Subject: Re: Using pure Java implementation of CVS
> On Mon, 2004-01-19 at 13:47, Emmanuel Venisse wrote:
> > ----- Original Message -----
> > From: "Eric Pugh" <ep...@upstate.com>
> > To: "Scm-Dev (E-mail)" <sc...@maven.apache.org>
> > Sent: Sunday, January 18, 2004 7:34 PM
> > Subject: Using pure Java implementation of CVS
> >
> >
> > > Hi all,
> > >
> > > JVZ dropped me a note about the progress on maven-scm and using the
pure
> > > Java CVS library in the generic-scm-providers/cvslib project. I'd be
> > happy
> > > to change the cvslib project to use the Java library that I used in
the
> > > ChangeLog plugin for Maven. I also have some refactoring ideas that
would
> > > make this a better implementation over what was used in ChangeLog.
> >
> > I'm -1 for the moment. The netbeans cvslib is under Sun License.
> > And I think it's more simple for a newbie if cvs module use command
line, He
> > can update and add new command more simply.
>
> Huh? There is no problem using Sun libraries and its use is already
> happening in the changelog.
>
> I actually think for a newbie not having to install CVS would be great,
> especially for continuum.
>
> I really don't see the need for a -1, please reconsider.
Yes, I already reconsider my opinion, and I authorized Eric to implement it
in a new provider (javacvs) for the moment.
We'll can delete current cvs provider later.
I think that Eric can be a maven-scm commiter.
Do you see that I add cvs tag command? You can test it with continuum.
>
> If you don't see the sense of it then Eric, I will still take the code
> for the native cvs lib provider and just place it under Continuum and
> use it there. That's the beauty of the provider.
>
> > >
> > > I changed StreamPumperTest in the scm-api project to not use the
> > deprecated
> > > StringBufferInputStream class. However, it appears that I don't have
> > karma
> > > for committing to scm-api. I can send in my changes as patch files if
you
> > > would prefer.
> >
> > I'll apply it.
> >
> > Emmanuel
>
> --
> jvz.
>
> Jason van Zyl
> jason@maven.org
> http://maven.apache.org
>
> happiness is like a butterfly: the more you chase it, the more it will
> elude you, but if you turn your attention to other things, it will come
> and sit softly on your shoulder ...
>
> -- Thoreau
>
>
Re: Using pure Java implementation of CVS
Posted by Jason van Zyl <jv...@maven.org>.
On Mon, 2004-01-19 at 13:47, Emmanuel Venisse wrote:
> ----- Original Message -----
> From: "Eric Pugh" <ep...@upstate.com>
> To: "Scm-Dev (E-mail)" <sc...@maven.apache.org>
> Sent: Sunday, January 18, 2004 7:34 PM
> Subject: Using pure Java implementation of CVS
>
>
> > Hi all,
> >
> > JVZ dropped me a note about the progress on maven-scm and using the pure
> > Java CVS library in the generic-scm-providers/cvslib project. I'd be
> happy
> > to change the cvslib project to use the Java library that I used in the
> > ChangeLog plugin for Maven. I also have some refactoring ideas that would
> > make this a better implementation over what was used in ChangeLog.
>
> I'm -1 for the moment. The netbeans cvslib is under Sun License.
> And I think it's more simple for a newbie if cvs module use command line, He
> can update and add new command more simply.
Huh? There is no problem using Sun libraries and its use is already
happening in the changelog.
I actually think for a newbie not having to install CVS would be great,
especially for continuum.
I really don't see the need for a -1, please reconsider.
If you don't see the sense of it then Eric, I will still take the code
for the native cvs lib provider and just place it under Continuum and
use it there. That's the beauty of the provider.
> >
> > I changed StreamPumperTest in the scm-api project to not use the
> deprecated
> > StringBufferInputStream class. However, it appears that I don't have
> karma
> > for committing to scm-api. I can send in my changes as patch files if you
> > would prefer.
>
> I'll apply it.
>
> Emmanuel
--
jvz.
Jason van Zyl
jason@maven.org
http://maven.apache.org
happiness is like a butterfly: the more you chase it, the more it will
elude you, but if you turn your attention to other things, it will come
and sit softly on your shoulder ...
-- Thoreau
Re: Using pure Java implementation of CVS
Posted by Emmanuel Venisse <em...@venisse.net>.
----- Original Message -----
From: "Eric Pugh" <ep...@upstate.com>
To: <sc...@maven.apache.org>
Sent: Tuesday, January 20, 2004 9:53 AM
Subject: RE: Using pure Java implementation of CVS
> JVZ suggested that instead of changing the existing provider cvslib, I
> create it as another provider. Part of the reason that I originally added
> the java lib was that our build machine didn't have CVS installed on it
(for
> stupid corporate reasons) and this meant that the changelog report
wouldn't
> run. Of course, I only fixed it for the changelog plugin, not for the
other
> plugins that use CVS, and I think that having this Maven-SCM project that
is
> in turn leveraged by all plugins etc that need SCM data is much better way
> to go!
OK, you can create a new provider that I'll add.
>
> What is I create generic-scm-providers/cvsjava or /javacvs and put the
code
> in there? That way, if there are licensing issues, which I don't think
> there are, then it can be made an optional, or hosted elsewhere. And,
since
> it wouldn't be the default, then those users who need it could, or
otherwise
> ignore it...
I prefer javacvs that is the original name of netbeans cvs implementation.
Actually, I think we can use a repository url like this scm:javacvs:.... to
launch cvs command with this provider. Do you have other ideas?
>
> Thoughts? I don't want to work on something that isn't going to be
included
> or used...
You can work on it :-)
For tests, you can use the test-repo module on codehaus cvs. In it we can do
what we want, it's reserved to maven-scm tests.
>
> Eric
>
> > -----Original Message-----
> > From: Emmanuel Venisse [mailto:emmanuel@venisse.net]
> > Sent: Monday, January 19, 2004 7:48 PM
> > To: scm-dev@maven.apache.org; epugh@upstate.com
> > Subject: Re: Using pure Java implementation of CVS
> >
> >
> >
> > ----- Original Message -----
> > From: "Eric Pugh" <ep...@upstate.com>
> > To: "Scm-Dev (E-mail)" <sc...@maven.apache.org>
> > Sent: Sunday, January 18, 2004 7:34 PM
> > Subject: Using pure Java implementation of CVS
> >
> >
> > > Hi all,
> > >
> > > JVZ dropped me a note about the progress on maven-scm and
> > using the pure
> > > Java CVS library in the generic-scm-providers/cvslib
> > project. I'd be
> > happy
> > > to change the cvslib project to use the Java library that I
> > used in the
> > > ChangeLog plugin for Maven. I also have some refactoring
> > ideas that would
> > > make this a better implementation over what was used in ChangeLog.
> >
> > I'm -1 for the moment. The netbeans cvslib is under Sun License.
> > And I think it's more simple for a newbie if cvs module use
> > command line, He
> > can update and add new command more simply.
> >
> > >
> > > I changed StreamPumperTest in the scm-api project to not use the
> > deprecated
> > > StringBufferInputStream class. However, it appears that I
> > don't have
> > karma
> > > for committing to scm-api. I can send in my changes as
> > patch files if you
> > > would prefer.
> >
> > I'll apply it.
> >
> > Emmanuel
>
>
RE: Using pure Java implementation of CVS
Posted by Eric Pugh <ep...@upstate.com>.
JVZ suggested that instead of changing the existing provider cvslib, I
create it as another provider. Part of the reason that I originally added
the java lib was that our build machine didn't have CVS installed on it (for
stupid corporate reasons) and this meant that the changelog report wouldn't
run. Of course, I only fixed it for the changelog plugin, not for the other
plugins that use CVS, and I think that having this Maven-SCM project that is
in turn leveraged by all plugins etc that need SCM data is much better way
to go!
What is I create generic-scm-providers/cvsjava or /javacvs and put the code
in there? That way, if there are licensing issues, which I don't think
there are, then it can be made an optional, or hosted elsewhere. And, since
it wouldn't be the default, then those users who need it could, or otherwise
ignore it...
Thoughts? I don't want to work on something that isn't going to be included
or used...
Eric
> -----Original Message-----
> From: Emmanuel Venisse [mailto:emmanuel@venisse.net]
> Sent: Monday, January 19, 2004 7:48 PM
> To: scm-dev@maven.apache.org; epugh@upstate.com
> Subject: Re: Using pure Java implementation of CVS
>
>
>
> ----- Original Message -----
> From: "Eric Pugh" <ep...@upstate.com>
> To: "Scm-Dev (E-mail)" <sc...@maven.apache.org>
> Sent: Sunday, January 18, 2004 7:34 PM
> Subject: Using pure Java implementation of CVS
>
>
> > Hi all,
> >
> > JVZ dropped me a note about the progress on maven-scm and
> using the pure
> > Java CVS library in the generic-scm-providers/cvslib
> project. I'd be
> happy
> > to change the cvslib project to use the Java library that I
> used in the
> > ChangeLog plugin for Maven. I also have some refactoring
> ideas that would
> > make this a better implementation over what was used in ChangeLog.
>
> I'm -1 for the moment. The netbeans cvslib is under Sun License.
> And I think it's more simple for a newbie if cvs module use
> command line, He
> can update and add new command more simply.
>
> >
> > I changed StreamPumperTest in the scm-api project to not use the
> deprecated
> > StringBufferInputStream class. However, it appears that I
> don't have
> karma
> > for committing to scm-api. I can send in my changes as
> patch files if you
> > would prefer.
>
> I'll apply it.
>
> Emmanuel
Re: Using pure Java implementation of CVS
Posted by Emmanuel Venisse <em...@venisse.net>.
----- Original Message -----
From: "Eric Pugh" <ep...@upstate.com>
To: "Scm-Dev (E-mail)" <sc...@maven.apache.org>
Sent: Sunday, January 18, 2004 7:34 PM
Subject: Using pure Java implementation of CVS
> Hi all,
>
> JVZ dropped me a note about the progress on maven-scm and using the pure
> Java CVS library in the generic-scm-providers/cvslib project. I'd be
happy
> to change the cvslib project to use the Java library that I used in the
> ChangeLog plugin for Maven. I also have some refactoring ideas that would
> make this a better implementation over what was used in ChangeLog.
I'm -1 for the moment. The netbeans cvslib is under Sun License.
And I think it's more simple for a newbie if cvs module use command line, He
can update and add new command more simply.
>
> I changed StreamPumperTest in the scm-api project to not use the
deprecated
> StringBufferInputStream class. However, it appears that I don't have
karma
> for committing to scm-api. I can send in my changes as patch files if you
> would prefer.
I'll apply it.
Emmanuel