You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "mumrah (via GitHub)" <gi...@apache.org> on 2023/01/30 17:38:25 UTC

[GitHub] [kafka] mumrah commented on a diff in pull request #13159: KAFKA-14656 Send UMR first during ZK migration

mumrah commented on code in PR #13159:
URL: https://github.com/apache/kafka/pull/13159#discussion_r1090943050


##########
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##########
@@ -403,7 +404,7 @@ public void run() throws Exception {
                 AtomicInteger count = new AtomicInteger(0);
                 zkMigrationClient.readAllMetadata(batch -> {
                     try {
-                        log.info("Migrating {} records from ZK: {}", batch.size(), batch);
+                        log.info("Migrating {} records from ZK", batch.size());

Review Comment:
   I wondered about that. So far, we are avoiding logging raw records in most places, but it could be very useful for debugging during a migration. I'll add it back as TRACE.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org