[GitHub] [cordova-plugin-inappbrowser] kamilbrk edited a comment on issue #514: Incorrect TypeScript typings in version 3.1.0

[GitBox <gi...@apache.org>]

kamilbrk edited a comment on issue #514: Incorrect TypeScript typings in version 3.1.0
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/514#issuecomment-517363685
 
 
   Most of typings on DefinitelyTyped add explicit `addEventListener`s, one by one. This seems to do the trick, rather than what happened here with `"one" | "two" | "three"`, no matter if it has my `| string` or not.
   
   I agree, adding `string` at the end makes it a bit useless, so it's either splitting them all to separate explicit definitions, like any other package, or making it a bit useless with this. Either of them would fix compilation errors.
   
   In fact, that's how typings in version 3.0.0 works and they never had that issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org