You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by Steve Loughran <st...@apache.org> on 2005/10/28 16:29:53 UTC
[Axis2] building under java1.5
I have axis2 building under java1.5, and DOM 3. The extra methods in the
interfaces are just stubs, but it compiles.
Trouble is, I can't check this stuff in without 1.4 builds breaking,
because one of the new methods uses a datatype that is only in dom3.
Otherwise we could stick the stuff in and they would be ignored
What to do? One solution might be to always build against dom3, but
support dom2 at runtime (and in tests).
-steve
Re: [Axis2] building under java1.5
Posted by Davanum Srinivas <da...@gmail.com>.
Since SAAJ 1.3 implements DOM3, i feel we should just move this stuff
to SAAJ module. What do you think?
-- dims
On 10/28/05, Steve Loughran <st...@apache.org> wrote:
> Davanum Srinivas wrote:
> > Steve,
> >
> > all org.w3c imports are ONLY in org.apache.axis2.om.impl.dom.*
> > package. This can be ripped out w/o affecting xml module.
> >
>
> I'm checking. OK, the files that changed there were
>
> AttrImpl, DocumentImpl, DOMImplementationImpl, NodeImpl, ParentNode,
> TextImpl
>
> and in org.apache.axis2.saaj:
>
> AttrImpl, NodeImpl, SOAPDocumentImpl, SOAPElementImpl,SOAPPartImpl and
> TextImpl
>
--
Davanum Srinivas : http://wso2.com/blogs/
Re: [Axis2] building under java1.5
Posted by Steve Loughran <st...@apache.org>.
Davanum Srinivas wrote:
> Steve,
>
> all org.w3c imports are ONLY in org.apache.axis2.om.impl.dom.*
> package. This can be ripped out w/o affecting xml module.
>
I'm checking. OK, the files that changed there were
AttrImpl, DocumentImpl, DOMImplementationImpl, NodeImpl, ParentNode,
TextImpl
and in org.apache.axis2.saaj:
AttrImpl, NodeImpl, SOAPDocumentImpl, SOAPElementImpl,SOAPPartImpl and
TextImpl
Re: [Axis2] building under java1.5
Posted by Davanum Srinivas <da...@gmail.com>.
Steve,
all org.w3c imports are ONLY in org.apache.axis2.om.impl.dom.*
package. This can be ripped out w/o affecting xml module.
-- dims
On 10/28/05, Davanum Srinivas <da...@gmail.com> wrote:
> that's wrong...OMElement should not depend on DOM2...let me check.
>
> -- dims
>
> On 10/28/05, Steve Loughran <st...@apache.org> wrote:
> > Davanum Srinivas wrote:
> > > Should we break out the DOM2/DOM3 stuff from xml module? just like we
> > > did for saaj?
> > >
> >
> > well, the issue is that both the OMElement and the SAAJ stuff declare
> > that they implement the dom interfaces, and you cannot build them on
> > java1.5 without marking every impl class as abstract. So I dont think
> > 'breaking out' is something
> > we can do.
> >
>
>
> --
> Davanum Srinivas : http://wso2.com/blogs/
>
--
Davanum Srinivas : http://wso2.com/blogs/
Re: [Axis2] building under java1.5
Posted by Davanum Srinivas <da...@gmail.com>.
that's wrong...OMElement should not depend on DOM2...let me check.
-- dims
On 10/28/05, Steve Loughran <st...@apache.org> wrote:
> Davanum Srinivas wrote:
> > Should we break out the DOM2/DOM3 stuff from xml module? just like we
> > did for saaj?
> >
>
> well, the issue is that both the OMElement and the SAAJ stuff declare
> that they implement the dom interfaces, and you cannot build them on
> java1.5 without marking every impl class as abstract. So I dont think
> 'breaking out' is something
> we can do.
>
--
Davanum Srinivas : http://wso2.com/blogs/
Re: [Axis2] building under java1.5
Posted by Davanum Srinivas <da...@gmail.com>.
Steve,
You should be all set now.
Steps:
- Fetch latest SVN
- Create a project.properties in root directory
-----------------------------------------------------------------------------
optional.includes=
-----------------------------------------------------------------------------
- Drop latest xalan jar in jdk15\jre\lib\endorsed
- Run "maven clean all-tests"
Thanks,
dims
PS: Ruchith can decide about DOM2/DOM3 later when he gets a chance.
On 10/28/05, Davanum Srinivas <da...@gmail.com> wrote:
> Folks,
>
> I've moved the dom stuff out of the way and made the saaj build
> optional. Now looking at test failures in JDK1.5
>
> thanks,
> -- dims
>
> On 10/28/05, Eran Chinthaka <ch...@opensource.lk> wrote:
> > Hi all, Ruchith ;-) ,
> >
> >
> > Ruchith Fernando wrote:
> > Hi All,
> >
> > The DOM impl that we have in the xml module implements the OM
> > interfaces. Therefore I included it under
> > org.apache.axis2.om.impl.dom.*
> > And I expected this to be used the same way we would use the llom
> > implementation of OM. (The linked list implementation of OM goes under
> > org.apache.axis2.om.impl.llom.*).
> >
> > But if you guys feel that the DOM stuff doesn't belong in the XML
> > module please feel free to (re?)move it :-).
> > remove it ? No way. Lets move it. We really need that.
> >
> > But I'd still like to
> > have a clean impl which implements DOM and OM interfaces.
> >
> > +1.
> >
> >
> > Thanks
> > Ruchith
> >
> > On 10/28/05, Eran Chinthaka <ch...@opensource.lk> wrote:
> >
> >
> > Steve Loughran wrote:
> >
> >
> >
> > Davanum Srinivas wrote:
> >
> >
> >
> > Should we break out the DOM2/DOM3 stuff from xml module? just like we
> > did for saaj?
> >
> >
> > well, the issue is that both the OMElement and the SAAJ stuff declare
> > that they implement the dom interfaces, and you cannot build them on
> > java1.5 without marking every impl class as abstract. So I dont think
> > 'breaking out' is something
> > we can do.
> >
> > This is COMPLETELY wrong idea. OM has nothing to do with dom impl.
> >
> > Actually I wanted to point this out earlier, but since Ruchith is doing
> > some important stuff, I kept quiet. I don't think dom impl stuff belongs
> > to OM. Its an extension of OM. This has made people to comment wrong on
> > OM, which Steve just did.
> >
> > As Dims stated, its better if we can strip this out from OM.
> >
> > -- Chinthaka
> >
> >
> >
> >
> >
> >
> > --
> > Ruchith
> >
> >
> >
> >
>
>
> --
> Davanum Srinivas : http://wso2.com/blogs/
>
--
Davanum Srinivas : http://wso2.com/blogs/
Re: [Axis2] building under java1.5
Posted by Steve Loughran <st...@apache.org>.
Davanum Srinivas wrote:
> Folks,
>
> I've moved the dom stuff out of the way and made the saaj build
> optional. Now looking at test failures in JDK1.5
>
> thanks,
> -- dims
Hey thanks, this is really good.
I've been using Java 1.5 for a while and most things work, with some caveats
-StringBuffer.toString() is very different; it copies the buffer out. If
you repeatedly call the function, your app will grind to a halt.
-proxy setup has changed a lot. As well as a system property to use the
OS (well IE and gnome) proxy settings, there are these new proxy classes
for custom proxy handling. We believe these try and to reverse-DNS
lookups too often for their own good for roaming laptops.
I've not encountered any axis2-specific problems.
-steve
Re: [Axis2] building under java1.5
Posted by Davanum Srinivas <da...@gmail.com>.
Folks,
I've moved the dom stuff out of the way and made the saaj build
optional. Now looking at test failures in JDK1.5
thanks,
-- dims
On 10/28/05, Eran Chinthaka <ch...@opensource.lk> wrote:
> Hi all, Ruchith ;-) ,
>
>
> Ruchith Fernando wrote:
> Hi All,
>
> The DOM impl that we have in the xml module implements the OM
> interfaces. Therefore I included it under
> org.apache.axis2.om.impl.dom.*
> And I expected this to be used the same way we would use the llom
> implementation of OM. (The linked list implementation of OM goes under
> org.apache.axis2.om.impl.llom.*).
>
> But if you guys feel that the DOM stuff doesn't belong in the XML
> module please feel free to (re?)move it :-).
> remove it ? No way. Lets move it. We really need that.
>
> But I'd still like to
> have a clean impl which implements DOM and OM interfaces.
>
> +1.
>
>
> Thanks
> Ruchith
>
> On 10/28/05, Eran Chinthaka <ch...@opensource.lk> wrote:
>
>
> Steve Loughran wrote:
>
>
>
> Davanum Srinivas wrote:
>
>
>
> Should we break out the DOM2/DOM3 stuff from xml module? just like we
> did for saaj?
>
>
> well, the issue is that both the OMElement and the SAAJ stuff declare
> that they implement the dom interfaces, and you cannot build them on
> java1.5 without marking every impl class as abstract. So I dont think
> 'breaking out' is something
> we can do.
>
> This is COMPLETELY wrong idea. OM has nothing to do with dom impl.
>
> Actually I wanted to point this out earlier, but since Ruchith is doing
> some important stuff, I kept quiet. I don't think dom impl stuff belongs
> to OM. Its an extension of OM. This has made people to comment wrong on
> OM, which Steve just did.
>
> As Dims stated, its better if we can strip this out from OM.
>
> -- Chinthaka
>
>
>
>
>
>
> --
> Ruchith
>
>
>
>
--
Davanum Srinivas : http://wso2.com/blogs/
Re: [Axis2] building under java1.5
Posted by Eran Chinthaka <ch...@opensource.lk>.
Hi all, Ruchith ;-) ,
Ruchith Fernando wrote:
>Hi All,
>
>The DOM impl that we have in the xml module implements the OM
>interfaces. Therefore I included it under
>org.apache.axis2.om.impl.dom.*
>And I expected this to be used the same way we would use the llom
>implementation of OM. (The linked list implementation of OM goes under
>org.apache.axis2.om.impl.llom.*).
>
>But if you guys feel that the DOM stuff doesn't belong in the XML
>module please feel free to (re?)move it :-).
>
remove it ? No way. Lets move it. We really need that.
>But I'd still like to
>have a clean impl which implements DOM and OM interfaces.
>
>
+1.
>Thanks
>Ruchith
>
>On 10/28/05, Eran Chinthaka <ch...@opensource.lk> wrote:
>
>
>>Steve Loughran wrote:
>>
>>
>>
>>>Davanum Srinivas wrote:
>>>
>>>
>>>
>>>>Should we break out the DOM2/DOM3 stuff from xml module? just like we
>>>>did for saaj?
>>>>
>>>>
>>>>
>>>well, the issue is that both the OMElement and the SAAJ stuff declare
>>>that they implement the dom interfaces, and you cannot build them on
>>>java1.5 without marking every impl class as abstract. So I dont think
>>>'breaking out' is something
>>>we can do.
>>>
>>>
>>This is COMPLETELY wrong idea. OM has nothing to do with dom impl.
>>
>>Actually I wanted to point this out earlier, but since Ruchith is doing
>>some important stuff, I kept quiet. I don't think dom impl stuff belongs
>>to OM. Its an extension of OM. This has made people to comment wrong on
>>OM, which Steve just did.
>>
>>As Dims stated, its better if we can strip this out from OM.
>>
>>-- Chinthaka
>>
>>
>>
>>>
>>>
>>
>>
>
>
>--
>Ruchith
>
>
>
>
Re: [Axis2] building under java1.5
Posted by Ruchith Fernando <ru...@gmail.com>.
Hi All,
The DOM impl that we have in the xml module implements the OM
interfaces. Therefore I included it under
org.apache.axis2.om.impl.dom.*
And I expected this to be used the same way we would use the llom
implementation of OM. (The linked list implementation of OM goes under
org.apache.axis2.om.impl.llom.*).
But if you guys feel that the DOM stuff doesn't belong in the XML
module please feel free to (re?)move it :-). But I'd still like to
have a clean impl which implements DOM and OM interfaces.
Thanks
Ruchith
On 10/28/05, Eran Chinthaka <ch...@opensource.lk> wrote:
>
>
> Steve Loughran wrote:
>
> > Davanum Srinivas wrote:
> >
> >> Should we break out the DOM2/DOM3 stuff from xml module? just like we
> >> did for saaj?
> >>
> >
> > well, the issue is that both the OMElement and the SAAJ stuff declare
> > that they implement the dom interfaces, and you cannot build them on
> > java1.5 without marking every impl class as abstract. So I dont think
> > 'breaking out' is something
> > we can do.
>
> This is COMPLETELY wrong idea. OM has nothing to do with dom impl.
>
> Actually I wanted to point this out earlier, but since Ruchith is doing
> some important stuff, I kept quiet. I don't think dom impl stuff belongs
> to OM. Its an extension of OM. This has made people to comment wrong on
> OM, which Steve just did.
>
> As Dims stated, its better if we can strip this out from OM.
>
> -- Chinthaka
>
> >
> >
>
>
--
Ruchith
Re: [Axis2] building under java1.5
Posted by Eran Chinthaka <ch...@opensource.lk>.
Steve Loughran wrote:
> Davanum Srinivas wrote:
>
>> Should we break out the DOM2/DOM3 stuff from xml module? just like we
>> did for saaj?
>>
>
> well, the issue is that both the OMElement and the SAAJ stuff declare
> that they implement the dom interfaces, and you cannot build them on
> java1.5 without marking every impl class as abstract. So I dont think
> 'breaking out' is something
> we can do.
This is COMPLETELY wrong idea. OM has nothing to do with dom impl.
Actually I wanted to point this out earlier, but since Ruchith is doing
some important stuff, I kept quiet. I don't think dom impl stuff belongs
to OM. Its an extension of OM. This has made people to comment wrong on
OM, which Steve just did.
As Dims stated, its better if we can strip this out from OM.
-- Chinthaka
>
>
Re: [Axis2] building under java1.5
Posted by Steve Loughran <st...@apache.org>.
Davanum Srinivas wrote:
> Should we break out the DOM2/DOM3 stuff from xml module? just like we
> did for saaj?
>
well, the issue is that both the OMElement and the SAAJ stuff declare
that they implement the dom interfaces, and you cannot build them on
java1.5 without marking every impl class as abstract. So I dont think
'breaking out' is something
we can do.
Re: [Axis2] building under java1.5
Posted by Davanum Srinivas <da...@gmail.com>.
Should we break out the DOM2/DOM3 stuff from xml module? just like we
did for saaj?
+1 from me.
-- dims
On 10/28/05, Steve Loughran <st...@apache.org> wrote:
> Davanum Srinivas wrote:
> > Steve,
> >
> > could we do a branch make the updates there to get a clearer picture?
> > - build against dom3
> > - try support dom2 at runtime
> > - update both the SAAJ and DOMImpl (to SAAJ 1.3 and DOM3)
> >
> > once we have stuff working we can merge back to trunk.
>
> would make sense. I havent played w/ SVN branching yet. if only the
> interface had stuck to core java datatypes; we could have been forward
> and backwards compatible.
>
--
Davanum Srinivas : http://wso2.com/blogs/
Re: [Axis2] building under java1.5
Posted by Steve Loughran <st...@apache.org>.
Davanum Srinivas wrote:
> Steve,
>
> could we do a branch make the updates there to get a clearer picture?
> - build against dom3
> - try support dom2 at runtime
> - update both the SAAJ and DOMImpl (to SAAJ 1.3 and DOM3)
>
> once we have stuff working we can merge back to trunk.
would make sense. I havent played w/ SVN branching yet. if only the
interface had stuck to core java datatypes; we could have been forward
and backwards compatible.
Re: [Axis2] building under java1.5
Posted by Davanum Srinivas <da...@gmail.com>.
Steve,
could we do a branch make the updates there to get a clearer picture?
- build against dom3
- try support dom2 at runtime
- update both the SAAJ and DOMImpl (to SAAJ 1.3 and DOM3)
once we have stuff working we can merge back to trunk.
thanks,
dims
On 10/28/05, Steve Loughran <st...@apache.org> wrote:
>
> I have axis2 building under java1.5, and DOM 3. The extra methods in the
> interfaces are just stubs, but it compiles.
>
> Trouble is, I can't check this stuff in without 1.4 builds breaking,
> because one of the new methods uses a datatype that is only in dom3.
> Otherwise we could stick the stuff in and they would be ignored
>
> What to do? One solution might be to always build against dom3, but
> support dom2 at runtime (and in tests).
>
> -steve
>
--
Davanum Srinivas : http://wso2.com/blogs/