You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "chickenlj (GitHub)" <gi...@apache.org> on 2019/04/11 07:55:15 UTC
[GitHub] [incubator-dubbo] chickenlj opened pull request #3853:
Revert #3688 config-center-config
## What is the purpose of the change
see issue described here https://github.com/apache/incubator-dubbo/issues/3682
## Brief changelog
XXXXX
## Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3853 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] ralf0131 commented on issue #3853: Revert
#3688 config-center-config
Posted by "ralf0131 (GitHub)" <gi...@apache.org>.
@tswstarplanet Could you please verify it?
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3853 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] chickenlj commented on issue #3853: Revert
#3688 config-center-config
Posted by "chickenlj (GitHub)" <gi...@apache.org>.
```java
class ExampleConfig {
// Dubbo will try to get "dubbo.example.alias_for_item=xxx" from .properties, if you want to use the original property
// "dubbo.example.item=xxx", you need to set useKeyAsProperty=false.
@Parameter(key = "alias_for_item")
public getItem() {
return value;
}
}
```
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3853 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] chickenlj commented on issue #3853: Revert
#3688 config-center-config
Posted by "chickenlj (GitHub)" <gi...@apache.org>.
```java
/**
* if {@link #key()} is specified, it will be used as the key for the annotated property when generating url.
* by default, this key will also be used to retrieve the config value:
* <pre>
* {@code
* class ExampleConfig {
* // Dubbo will try to get "dubbo.example.alias_for_item=xxx" from .properties, if you want to use the original property
* // "dubbo.example.item=xxx", you need to set useKeyAsProperty=false.
* @Parameter(key = "alias_for_item")
* public getItem();
* }
* }
*
* </pre>
*/
boolean useKeyAsProperty() default true; boolean useKeyAsProperty() default true;
```
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3853 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] chickenlj commented on issue #3853: Revert
#3688 config-center-config
Posted by "chickenlj (GitHub)" <gi...@apache.org>.
```java
class ExampleConfig {
// Dubbo will try to get "dubbo.example.alias_for_item=xxx" from .properties, if you want to use the original property
// "dubbo.example.item=xxx", you need to set useKeyAsProperty=false.
@Parameter(key = "alias_for_item")
public getItem() {
return "xxx";
}
}
```
Only key is set or not matters:
URL: dubbo://xxxxx?alias_for_item=xxxx
```properties
# when useKeyAsProperty=true.
dubbo.example.alias_for_item=xxx
# useKeyAsProperty=false.
dubbo.example.item=xxx
```
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3853 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org