You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/11/10 19:02:13 UTC
[GitHub] [accumulo] DomGarguilo opened a new issue #2355: `while(false)` loop in DatafileManager
DomGarguilo opened a new issue #2355:
URL: https://github.com/apache/accumulo/issues/2355
In DatafileManager,java, there is a while-loop whose condition, a boolean value, is always false - meaning the loop will never be entered. The boolean is instantiated as false and never changed. My first thought was to just remove the unused loop and its boolean condition however I first wanted to see if anyone knew what was supposed to be going on here.
The boolean value:
https://github.com/apache/accumulo/blob/52e80b1d11f0093a07a2d886d85aa74f7998096b/server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileManager.java#L84
The while loop (only places that the above boolean is used):
https://github.com/apache/accumulo/blob/52e80b1d11f0093a07a2d886d85aa74f7998096b/server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileManager.java#L95-L101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime closed issue #2355: Remove unused code in DatafileManager
Posted by GitBox <gi...@apache.org>.
milleruntime closed issue #2355:
URL: https://github.com/apache/accumulo/issues/2355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on issue #2355: `while(false)` in DatafileManager
Posted by GitBox <gi...@apache.org>.
milleruntime commented on issue #2355:
URL: https://github.com/apache/accumulo/issues/2355#issuecomment-967066273
> The code in #1490 looks like it became vestigial after fixing issue #936 in PR #1313. The code here is now also vestigial. It was only ever used for scanning the root tablet when we relied on HDFS being the canonical source of truth for the files the root tablet was using. Since #1313, that is no longer needed. This can be cleaned up.
I had a feeling this was the case but wasn't able to confirm it looking at the code. Thanks for looking at this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on issue #2355: `while(false)` in DatafileManager
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on issue #2355:
URL: https://github.com/apache/accumulo/issues/2355#issuecomment-966441246
The code in #1490 looks like it became vestigial after fixing issue #936 in PR #1313. The code here is now also vestigial. It was only ever used for scanning the root tablet when we relied on HDFS being the canonical source of truth for the files the root tablet was using. Since #1313, that is no longer needed. This can be cleaned up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] filipedfr commented on issue #2355: Remove unused code in DatafileManager
Posted by GitBox <gi...@apache.org>.
filipedfr commented on issue #2355:
URL: https://github.com/apache/accumulo/issues/2355#issuecomment-1012709978
Worked this out in PR #2418. Sorry if I forgot to request assignment first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Manno15 commented on issue #2355: `while(false)` in DatafileManager
Posted by GitBox <gi...@apache.org>.
Manno15 commented on issue #2355:
URL: https://github.com/apache/accumulo/issues/2355#issuecomment-965659663
Seems some code was removed in #1490 that did change the value of `reservationsBlocked to true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org