You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tajo.apache.org by "Hyunsik Choi (JIRA)" <ji...@apache.org> on 2013/07/30 18:23:48 UTC
[jira] [Commented] (TAJO-96) Design and implement rewrite rule
interface and the rewrite rule engine.
[ https://issues.apache.org/jira/browse/TAJO-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13724013#comment-13724013 ]
Hyunsik Choi commented on TAJO-96:
----------------------------------
I've uploaded the first patch in asf reviewboard.
https://reviews.apache.org/r/13064/
> Design and implement rewrite rule interface and the rewrite rule engine.
> ------------------------------------------------------------------------
>
> Key: TAJO-96
> URL: https://issues.apache.org/jira/browse/TAJO-96
> Project: Tajo
> Issue Type: Sub-task
> Components: optimizer
> Reporter: Hyunsik Choi
> Assignee: Hyunsik Choi
> Labels: rewrite
> Fix For: 0.2-incubating
>
>
> So far, some rewrite rules are embedded in LogicalOptimizer and LogicalPlanner. In order to encourage contributors to implement more useful rewrite rules, we need well-designed rewrite rule interface and the rewrite rule engine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Commented] (TAJO-96) Design and implement rewrite rule interface and the rewrite rule engine.
Posted by camelia c <ca...@yahoo.com>.
Hello,
I looked into the code You uploaded in the review board and , as You asked if I have any suggestions, in my humble opinion we could write several classes implementing the rewrite engine interface, e.g. one for the outer join transformation, another for selection pushdown and so on.
This would be particularly useful for the rewriting algorithm used in outer join transformation.
Furthermore, the rewriting is carried out in stages, so we cannot put all rules in the same collection and apply all eligible ones one one node at the same time.
Thank You!
Yours sincerely,
Camelia
________________________________
From: Hyunsik Choi (JIRA) <ji...@apache.org>
To: dev@tajo.incubator.apache.org
Sent: Tuesday, July 30, 2013 7:23 PM
Subject: [jira] [Commented] (TAJO-96) Design and implement rewrite rule interface and the rewrite rule engine.
[ https://issues.apache.org/jira/browse/TAJO-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13724013#comment-13724013 ]
Hyunsik Choi commented on TAJO-96:
----------------------------------
I've uploaded the first patch in asf reviewboard.
https://reviews.apache.org/r/13064/
> Design and implement rewrite rule interface and the rewrite rule engine.
> ------------------------------------------------------------------------
>
> Key: TAJO-96
> URL: https://issues.apache.org/jira/browse/TAJO-96
> Project: Tajo
> Issue Type: Sub-task
> Components: optimizer
> Reporter: Hyunsik Choi
> Assignee: Hyunsik Choi
> Labels: rewrite
> Fix For: 0.2-incubating
>
>
> So far, some rewrite rules are embedded in LogicalOptimizer and LogicalPlanner. In order to encourage contributors to implement more useful rewrite rules, we need well-designed rewrite rule interface and the rewrite rule engine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira