[GitHub] [incubator-inlong] woofyzhao commented on a diff in pull request #4694: [INLONG-4632][Manager] Abstract operations on sink configuration to reduce repetitive code

[GitBox <gi...@apache.org>]

woofyzhao commented on code in PR #4694:
URL: https://github.com/apache/incubator-inlong/pull/4694#discussion_r901059571


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sink/iceberg/IcebergSinkOperation.java:
##########
@@ -41,101 +38,34 @@
 import org.apache.inlong.manager.common.util.Preconditions;
 import org.apache.inlong.manager.dao.entity.StreamSinkEntity;
 import org.apache.inlong.manager.dao.entity.StreamSinkFieldEntity;
-import org.apache.inlong.manager.dao.mapper.StreamSinkEntityMapper;
 import org.apache.inlong.manager.dao.mapper.StreamSinkFieldEntityMapper;
-import org.apache.inlong.manager.service.sink.StreamSinkOperation;
+import org.apache.inlong.manager.service.sink.AbstractSinkOperator;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.stereotype.Service;
 
-import java.util.ArrayList;
-import java.util.Date;
 import java.util.List;
 import java.util.function.Supplier;
 
 /**
  * Iceberg sink operation, such as save or update iceberg field, etc.
  */
 @Service
-public class IcebergSinkOperation implements StreamSinkOperation {
+public class IcebergSinkOperation extends AbstractSinkOperator {
 
     private static final Logger LOGGER = LoggerFactory.getLogger(IcebergSinkOperation.class);
 
     @Autowired
     private ObjectMapper objectMapper;
     @Autowired
-    private StreamSinkEntityMapper sinkMapper;
-    @Autowired
     private StreamSinkFieldEntityMapper sinkFieldMapper;
 
     @Override
     public Boolean accept(SinkType sinkType) {
         return SinkType.ICEBERG.equals(sinkType);
     }
 
-    @Override
-    public Integer saveOpt(SinkRequest request, String operator) {
-        String sinkType = request.getSinkType();
-        Preconditions.checkTrue(SinkType.SINK_ICEBERG.equals(sinkType),
-                ErrorCodeEnum.SINK_TYPE_NOT_SUPPORT.getMessage() + ": " + sinkType);
-
-        IcebergSinkRequest icebergSinkRequest = (IcebergSinkRequest) request;
-        StreamSinkEntity entity = CommonBeanUtils.copyProperties(icebergSinkRequest, StreamSinkEntity::new);
-        entity.setStatus(SinkStatus.NEW.getCode());
-        entity.setIsDeleted(GlobalConstants.UN_DELETED);
-        entity.setCreator(operator);
-        entity.setModifier(operator);
-        Date now = new Date();
-        entity.setCreateTime(now);
-        entity.setModifyTime(now);
-
-        // get the ext params
-        IcebergSinkDTO dto = IcebergSinkDTO.getFromRequest(icebergSinkRequest);
-        try {
-            entity.setExtParams(objectMapper.writeValueAsString(dto));
-        } catch (Exception e) {
-            throw new BusinessException(ErrorCodeEnum.SINK_SAVE_FAILED);
-        }
-        sinkMapper.insert(entity);
-        Integer sinkId = entity.getId();
-        request.setId(sinkId);
-        this.saveFieldOpt(request);
-        return sinkId;
-    }
-
-    @Override
-    public void saveFieldOpt(SinkRequest request) {
-        List<SinkField> fieldList = request.getSinkFieldList();
-        LOGGER.info("begin to save iceberg field={}", fieldList);
-        if (CollectionUtils.isEmpty(fieldList)) {
-            return;
-        }
-
-        int size = fieldList.size();
-        List<StreamSinkFieldEntity> entityList = new ArrayList<>(size);
-        String groupId = request.getInlongGroupId();
-        String streamId = request.getInlongStreamId();
-        String sinkType = request.getSinkType();
-        Integer sinkId = request.getId();
-        for (SinkField fieldInfo : fieldList) {
-            checkFieldInfo(fieldInfo);

Review Comment:
   This check is dropped. Try add it back somewhere.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org