You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2024/04/07 09:26:29 UTC
[PR] [SPARK-47755][CONNECT] Pivot should fail when the number of distinct values is too large [spark]
zhengruifeng opened a new pull request, #45918:
URL: https://github.com/apache/spark/pull/45918
### What changes were proposed in this pull request?
`Pivot` should fail when the number of distinct values is too large
### Why are the changes needed?
Following check is missing in Spark Connect
```
if (values.length > maxValues) {
throw QueryCompilationErrors.aggregationFunctionAppliedOnNonNumericColumnError(
pivotColumn.toString, maxValues)
}
```
### Does this PR introduce _any_ user-facing change?
pivot will fail when the number of distinct values exceed `DATAFRAME_PIVOT_MAX_VALUES`
and so will be consistent with classic spark.
### How was this patch tested?
added test
### Was this patch authored or co-authored using generative AI tooling?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47755][CONNECT] Pivot should fail when the number of distinct values is too large [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #45918:
URL: https://github.com/apache/spark/pull/45918#issuecomment-2041652839
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47755][CONNECT] Pivot should fail when the number of distinct values is too large [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #45918: [SPARK-47755][CONNECT] Pivot should fail when the number of distinct values is too large
URL: https://github.com/apache/spark/pull/45918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org