You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Jim Gomes (JIRA)" <ji...@apache.org> on 2007/09/13 01:17:22 UTC
[jira] Created: (AMQNET-61) Auto-Acknowledgement Mode always sends
unnecessary ACK message
Auto-Acknowledgement Mode always sends unnecessary ACK message
--------------------------------------------------------------
Key: AMQNET-61
URL: https://issues.apache.org/activemq/browse/AMQNET-61
Project: ActiveMQ .Net
Issue Type: Bug
Components: ActiveMQ Client, MSMQ, Stomp
Environment: Windows XP SP2
.NET 2.0
Reporter: Jim Gomes
Assignee: James Strachan
Priority: Minor
When a MessageConsumer receives a message, it sends a MessageAck even when the acknowledgment mode is set to AutoAcknowledge. This results in an error message being sent back to the client stating that there is no such message to acknowledge.
According to standard JMS semantics, when AutoAcknowledge mode is used, the client does not need to (and apparently should not) send back an ACK message. An ACK message should only be sent back when the subscription is in ClientAcknowledge or DupsOkAcknowledge mode. Sending back unnecessary responses creates unnecessary network traffic and load on a high-speed server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (AMQNET-61) Auto-Acknowledgement Mode
always sends unnecessary ACK message
Posted by "Jim Gomes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQNET-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40133 ]
semog edited comment on AMQNET-61 at 9/12/07 5:01 PM:
----------------------------------------------------------
Added a new {{AutoClientAcknowledge}} mode that will put the consumer into client acknowledgment mode and will send the ACK message automatically. This is the same action that {{AutoAcknowledge}} would perform prior to this fix. I then changed the {{AutoAcknowledge}} mode to *not* send an ACK message back to the server.
Note: the patch for MessageConsumer.cs was generated after applying the patches for [AMQNET-55].
Note: the patch for StompWireFormat.cs was generated after applying the patches for [AMQNET-53], [AMQNET-56], and [AMQNET-59].
was (Author: semog):
Added a new {{AutoClientAcknowledge}} mode that will put the consumer into client acknowledgment mode and will send the ACK message automatically. This is the same action that {{AutoAcknowledge}} would perform prior to this fix. I then changed the {{AutoAcknowledge}} mode to *not* send an ACK message back to the server.
> Auto-Acknowledgement Mode always sends unnecessary ACK message
> --------------------------------------------------------------
>
> Key: AMQNET-61
> URL: https://issues.apache.org/activemq/browse/AMQNET-61
> Project: ActiveMQ .Net
> Issue Type: Bug
> Components: ActiveMQ Client, MSMQ, Stomp
> Environment: Windows XP SP2
> .NET 2.0
> Reporter: Jim Gomes
> Assignee: James Strachan
> Priority: Minor
> Attachments: IConnection.cs.patch.txt, MessageConsumer.cs.patch.txt, StompWireFormat.cs.patch.txt
>
>
> When a MessageConsumer receives a message, it sends a MessageAck even when the acknowledgment mode is set to AutoAcknowledge. This results in an error message being sent back to the client stating that there is no such message to acknowledge.
> According to standard JMS semantics, when AutoAcknowledge mode is used, the client does not need to (and apparently should not) send back an ACK message. An ACK message should only be sent back when the subscription is in ClientAcknowledge or DupsOkAcknowledge mode. Sending back unnecessary responses creates unnecessary network traffic and load on a high-speed server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AMQNET-61) Auto-Acknowledgement Mode always sends
unnecessary ACK message
Posted by "Jim Gomes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQNET-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Gomes updated AMQNET-61:
----------------------------
Attachment: MessageConsumer.cs.patch.txt
StompWireFormat.cs.patch.txt
IConnection.cs.patch.txt
Added a new {{AutoClientAcknowledge}} mode that will put the consumer into client acknowledgment mode and will send the ACK message automatically. This is the same action that {{AutoAcknowledge}} would perform prior to this fix. I then changed the {{AutoAcknowledge}} mode to *not* send an ACK message back to the server.
> Auto-Acknowledgement Mode always sends unnecessary ACK message
> --------------------------------------------------------------
>
> Key: AMQNET-61
> URL: https://issues.apache.org/activemq/browse/AMQNET-61
> Project: ActiveMQ .Net
> Issue Type: Bug
> Components: ActiveMQ Client, MSMQ, Stomp
> Environment: Windows XP SP2
> .NET 2.0
> Reporter: Jim Gomes
> Assignee: James Strachan
> Priority: Minor
> Attachments: IConnection.cs.patch.txt, MessageConsumer.cs.patch.txt, StompWireFormat.cs.patch.txt
>
>
> When a MessageConsumer receives a message, it sends a MessageAck even when the acknowledgment mode is set to AutoAcknowledge. This results in an error message being sent back to the client stating that there is no such message to acknowledge.
> According to standard JMS semantics, when AutoAcknowledge mode is used, the client does not need to (and apparently should not) send back an ACK message. An ACK message should only be sent back when the subscription is in ClientAcknowledge or DupsOkAcknowledge mode. Sending back unnecessary responses creates unnecessary network traffic and load on a high-speed server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (AMQNET-61) Auto-Acknowledgement Mode always sends
unnecessary ACK message
Posted by "Jim Gomes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQNET-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Gomes closed AMQNET-61.
---------------------------
> Auto-Acknowledgement Mode always sends unnecessary ACK message
> --------------------------------------------------------------
>
> Key: AMQNET-61
> URL: https://issues.apache.org/activemq/browse/AMQNET-61
> Project: ActiveMQ .Net
> Issue Type: Bug
> Components: ActiveMQ Client, MSMQ, Stomp
> Environment: Windows XP SP2
> .NET 2.0
> Reporter: Jim Gomes
> Assignee: James Strachan
> Priority: Minor
> Attachments: IConnection.cs.patch.txt, MessageConsumer.cs.patch.txt, StompWireFormat.cs.patch.txt
>
>
> When a MessageConsumer receives a message, it sends a MessageAck even when the acknowledgment mode is set to AutoAcknowledge. This results in an error message being sent back to the client stating that there is no such message to acknowledge.
> According to standard JMS semantics, when AutoAcknowledge mode is used, the client does not need to (and apparently should not) send back an ACK message. An ACK message should only be sent back when the subscription is in ClientAcknowledge or DupsOkAcknowledge mode. Sending back unnecessary responses creates unnecessary network traffic and load on a high-speed server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (AMQNET-61) Auto-Acknowledgement Mode always sends
unnecessary ACK message
Posted by "Jim Gomes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQNET-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Gomes resolved AMQNET-61.
-----------------------------
Resolution: Fixed
> Auto-Acknowledgement Mode always sends unnecessary ACK message
> --------------------------------------------------------------
>
> Key: AMQNET-61
> URL: https://issues.apache.org/activemq/browse/AMQNET-61
> Project: ActiveMQ .Net
> Issue Type: Bug
> Components: ActiveMQ Client, MSMQ, Stomp
> Environment: Windows XP SP2
> .NET 2.0
> Reporter: Jim Gomes
> Assignee: James Strachan
> Priority: Minor
> Attachments: IConnection.cs.patch.txt, MessageConsumer.cs.patch.txt, StompWireFormat.cs.patch.txt
>
>
> When a MessageConsumer receives a message, it sends a MessageAck even when the acknowledgment mode is set to AutoAcknowledge. This results in an error message being sent back to the client stating that there is no such message to acknowledge.
> According to standard JMS semantics, when AutoAcknowledge mode is used, the client does not need to (and apparently should not) send back an ACK message. An ACK message should only be sent back when the subscription is in ClientAcknowledge or DupsOkAcknowledge mode. Sending back unnecessary responses creates unnecessary network traffic and load on a high-speed server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AMQNET-61) Auto-Acknowledgement Mode always
sends unnecessary ACK message
Posted by "Jim Gomes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQNET-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=40986#action_40986 ]
Jim Gomes commented on AMQNET-61:
---------------------------------
I re-worked this part of the code. The AutoClientAcknowledge mode was causing certain problems with STOMPConnect and messages were not being removed from the queue. Instead, I added the option to ignore error returns on asynchronous message acknowledgment. The result of the ACK is discarded, so any error generated by it should also be discarded. The upshot is that the AutoClientAcknowledge mode was completely removed.
> Auto-Acknowledgement Mode always sends unnecessary ACK message
> --------------------------------------------------------------
>
> Key: AMQNET-61
> URL: https://issues.apache.org/activemq/browse/AMQNET-61
> Project: ActiveMQ .Net
> Issue Type: Bug
> Components: ActiveMQ Client, MSMQ, Stomp
> Environment: Windows XP SP2
> .NET 2.0
> Reporter: Jim Gomes
> Assignee: James Strachan
> Priority: Minor
> Attachments: IConnection.cs.patch.txt, MessageConsumer.cs.patch.txt, StompWireFormat.cs.patch.txt
>
>
> When a MessageConsumer receives a message, it sends a MessageAck even when the acknowledgment mode is set to AutoAcknowledge. This results in an error message being sent back to the client stating that there is no such message to acknowledge.
> According to standard JMS semantics, when AutoAcknowledge mode is used, the client does not need to (and apparently should not) send back an ACK message. An ACK message should only be sent back when the subscription is in ClientAcknowledge or DupsOkAcknowledge mode. Sending back unnecessary responses creates unnecessary network traffic and load on a high-speed server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.