[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #233: Warn when DFDL properties are ignored

[GitBox <gi...@apache.org>]

stevedlawrence commented on a change in pull request #233: Warn when DFDL properties are ignored
URL: https://github.com/apache/incubator-daffodil/pull/233#discussion_r293918216
 
 

 ##########
 File path: daffodil-test/src/test/resources/org/apache/daffodil/section12/aligned_data/Aligned_Data.tdml
 ##########
 @@ -267,9 +267,9 @@
     <xs:element name="e16">
       <xs:complexType>
         <xs:sequence>
-          <xs:element name="e14" type="xs:string" dfdl:terminator=":" dfdl:representation="text" dfdl:lengthKind="explicit" dfdl:length="5" dfdl:encoding="ascii" 
 
 Review comment:
   I don't do any checks for redundant properties, though that's an interesting idea. However, there are probably cases were someone wants to be explicit about a certain property on an element even though it's redundant to the default properties. We could add it, but i'm not sure it gives as much benefit as this check.
   
   dfdl:representation="text" was removed anytime it was on a type with xs:string or xs:hexBinary. Elements with these types have an implied representation (text or binary respectively) and so we never access the representation property. So this is correct as far as warning about an unused property. This particular one probably never means a user made an error though.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services