You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by David Robinson <dr...@twitter.com> on 2014/01/24 02:24:41 UTC

Review Request 17293: s/thermos_observe/thermos_observer/ in README.md

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17293/
-----------------------------------------------------------

Review request for Aurora, Jonathan Boulle and Brian Wickman.


Repository: aurora


Description
-------

s/thermos_observe/thermos_observer/ in README.md


Diffs
-----

  src/main/python/apache/thermos/README.md 4bfefd37163dfbc5947acc7adc52f57c95cd174f 

Diff: https://reviews.apache.org/r/17293/diff/


Testing
-------

None, it's a document and it's out of date.


Thanks,

David Robinson


Re: Review Request 17293: s/thermos_observe/thermos_observer/ in README.md

Posted by Jonathan Boulle <jo...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17293/#review32883
-----------------------------------------------------------

Ship it!


Ship It!

- Jonathan Boulle


On Jan. 24, 2014, 1:28 a.m., David Robinson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17293/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2014, 1:28 a.m.)
> 
> 
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> s/thermos_observe/thermos_observer/ in README.md
> 
> [drobinson@x1 incubator-aurora (master)]$ grep thermos_observe * -R
> examples/vagrant/provision-dev-environment.sh:  ./pants src/main/python/apache/thermos/observer/bin:thermos_observer
> examples/vagrant/provision-dev-environment.sh:  for pex in aurora_admin aurora_client gc_executor thermos_executor thermos_observer; do
> examples/vagrant/provision-mesos-slave.sh:cat > /usr/local/bin/thermos_observer.sh <<"EOF"
> examples/vagrant/provision-mesos-slave.sh:    /usr/local/bin/thermos_observer \
> examples/vagrant/provision-mesos-slave.sh:chmod +x /usr/local/bin/thermos_observer.sh
> examples/vagrant/provision-mesos-slave.sh:install -m 755 /vagrant/dist/thermos_observer.pex /usr/local/bin/thermos_observer
> examples/vagrant/provision-mesos-slave.sh:/usr/local/bin/thermos_observer.sh >/var/log/thermos-observer.log 2>&1
> src/main/python/apache/thermos/README.md:$ ./pants src/python/apache/thermos/bin:thermos_observe
> src/main/python/apache/thermos/README.md:$ dist/thermos_observe.pex --root=$HOME/.thermos
> src/main/python/apache/thermos/README.md:$ thermos simplerun --daemon -P http:1338 'dist/thermos_observe.pex --http_port={{thermos.ports[http]}} --root=$HOME/.thermos'
> src/main/python/apache/thermos/observer/bin/BUILD:  name = 'thermos_observer',
> src/main/python/apache/thermos/observer/bin/BUILD:  source = 'thermos_observer.py',
> src/main/python/apache/thermos/observer/bin/BUILD:  entry_point = 'apache.thermos.observer.bin.thermos_observer:proxy_main',
> src/main/python/apache/thermos/observer/BUILD:    thermos_observer = pants('src/main/python/apache/thermos/observer/bin:thermos_observer'),
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/thermos/README.md 4bfefd37163dfbc5947acc7adc52f57c95cd174f 
> 
> Diff: https://reviews.apache.org/r/17293/diff/
> 
> 
> Testing
> -------
> 
> None, it's a document and it's out of date.
> 
> 
> Thanks,
> 
> David Robinson
> 
>


Re: Review Request 17293: s/thermos_observe/thermos_observer/ in README.md

Posted by Brian Wickman <wi...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17293/#review33014
-----------------------------------------------------------

Ship it!


Ship It!

- Brian Wickman


On Jan. 24, 2014, 1:28 a.m., David Robinson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17293/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2014, 1:28 a.m.)
> 
> 
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> s/thermos_observe/thermos_observer/ in README.md
> 
> [drobinson@x1 incubator-aurora (master)]$ grep thermos_observe * -R
> examples/vagrant/provision-dev-environment.sh:  ./pants src/main/python/apache/thermos/observer/bin:thermos_observer
> examples/vagrant/provision-dev-environment.sh:  for pex in aurora_admin aurora_client gc_executor thermos_executor thermos_observer; do
> examples/vagrant/provision-mesos-slave.sh:cat > /usr/local/bin/thermos_observer.sh <<"EOF"
> examples/vagrant/provision-mesos-slave.sh:    /usr/local/bin/thermos_observer \
> examples/vagrant/provision-mesos-slave.sh:chmod +x /usr/local/bin/thermos_observer.sh
> examples/vagrant/provision-mesos-slave.sh:install -m 755 /vagrant/dist/thermos_observer.pex /usr/local/bin/thermos_observer
> examples/vagrant/provision-mesos-slave.sh:/usr/local/bin/thermos_observer.sh >/var/log/thermos-observer.log 2>&1
> src/main/python/apache/thermos/README.md:$ ./pants src/python/apache/thermos/bin:thermos_observe
> src/main/python/apache/thermos/README.md:$ dist/thermos_observe.pex --root=$HOME/.thermos
> src/main/python/apache/thermos/README.md:$ thermos simplerun --daemon -P http:1338 'dist/thermos_observe.pex --http_port={{thermos.ports[http]}} --root=$HOME/.thermos'
> src/main/python/apache/thermos/observer/bin/BUILD:  name = 'thermos_observer',
> src/main/python/apache/thermos/observer/bin/BUILD:  source = 'thermos_observer.py',
> src/main/python/apache/thermos/observer/bin/BUILD:  entry_point = 'apache.thermos.observer.bin.thermos_observer:proxy_main',
> src/main/python/apache/thermos/observer/BUILD:    thermos_observer = pants('src/main/python/apache/thermos/observer/bin:thermos_observer'),
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/thermos/README.md 4bfefd37163dfbc5947acc7adc52f57c95cd174f 
> 
> Diff: https://reviews.apache.org/r/17293/diff/
> 
> 
> Testing
> -------
> 
> None, it's a document and it's out of date.
> 
> 
> Thanks,
> 
> David Robinson
> 
>


Re: Review Request 17293: s/thermos_observe/thermos_observer/ in README.md

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17293/#review38107
-----------------------------------------------------------


Looks like committers neglected to put this on master.  It's now on master as 482d7a4.

- Bill Farner


On Jan. 24, 2014, 1:28 a.m., David Robinson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17293/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2014, 1:28 a.m.)
> 
> 
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> s/thermos_observe/thermos_observer/ in README.md
> 
> [drobinson@x1 incubator-aurora (master)]$ grep thermos_observe * -R
> examples/vagrant/provision-dev-environment.sh:  ./pants src/main/python/apache/thermos/observer/bin:thermos_observer
> examples/vagrant/provision-dev-environment.sh:  for pex in aurora_admin aurora_client gc_executor thermos_executor thermos_observer; do
> examples/vagrant/provision-mesos-slave.sh:cat > /usr/local/bin/thermos_observer.sh <<"EOF"
> examples/vagrant/provision-mesos-slave.sh:    /usr/local/bin/thermos_observer \
> examples/vagrant/provision-mesos-slave.sh:chmod +x /usr/local/bin/thermos_observer.sh
> examples/vagrant/provision-mesos-slave.sh:install -m 755 /vagrant/dist/thermos_observer.pex /usr/local/bin/thermos_observer
> examples/vagrant/provision-mesos-slave.sh:/usr/local/bin/thermos_observer.sh >/var/log/thermos-observer.log 2>&1
> src/main/python/apache/thermos/README.md:$ ./pants src/python/apache/thermos/bin:thermos_observe
> src/main/python/apache/thermos/README.md:$ dist/thermos_observe.pex --root=$HOME/.thermos
> src/main/python/apache/thermos/README.md:$ thermos simplerun --daemon -P http:1338 'dist/thermos_observe.pex --http_port={{thermos.ports[http]}} --root=$HOME/.thermos'
> src/main/python/apache/thermos/observer/bin/BUILD:  name = 'thermos_observer',
> src/main/python/apache/thermos/observer/bin/BUILD:  source = 'thermos_observer.py',
> src/main/python/apache/thermos/observer/bin/BUILD:  entry_point = 'apache.thermos.observer.bin.thermos_observer:proxy_main',
> src/main/python/apache/thermos/observer/BUILD:    thermos_observer = pants('src/main/python/apache/thermos/observer/bin:thermos_observer'),
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/thermos/README.md 4bfefd37163dfbc5947acc7adc52f57c95cd174f 
> 
> Diff: https://reviews.apache.org/r/17293/diff/
> 
> 
> Testing
> -------
> 
> None, it's a document and it's out of date.
> 
> 
> Thanks,
> 
> David Robinson
> 
>


Re: Review Request 17293: s/thermos_observe/thermos_observer/ in README.md

Posted by David Robinson <dr...@twitter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17293/
-----------------------------------------------------------

(Updated Jan. 24, 2014, 1:28 a.m.)


Review request for Aurora, Jonathan Boulle and Brian Wickman.


Repository: aurora


Description (updated)
-------

s/thermos_observe/thermos_observer/ in README.md

[drobinson@x1 incubator-aurora (master)]$ grep thermos_observe * -R
examples/vagrant/provision-dev-environment.sh:  ./pants src/main/python/apache/thermos/observer/bin:thermos_observer
examples/vagrant/provision-dev-environment.sh:  for pex in aurora_admin aurora_client gc_executor thermos_executor thermos_observer; do
examples/vagrant/provision-mesos-slave.sh:cat > /usr/local/bin/thermos_observer.sh <<"EOF"
examples/vagrant/provision-mesos-slave.sh:    /usr/local/bin/thermos_observer \
examples/vagrant/provision-mesos-slave.sh:chmod +x /usr/local/bin/thermos_observer.sh
examples/vagrant/provision-mesos-slave.sh:install -m 755 /vagrant/dist/thermos_observer.pex /usr/local/bin/thermos_observer
examples/vagrant/provision-mesos-slave.sh:/usr/local/bin/thermos_observer.sh >/var/log/thermos-observer.log 2>&1
src/main/python/apache/thermos/README.md:$ ./pants src/python/apache/thermos/bin:thermos_observe
src/main/python/apache/thermos/README.md:$ dist/thermos_observe.pex --root=$HOME/.thermos
src/main/python/apache/thermos/README.md:$ thermos simplerun --daemon -P http:1338 'dist/thermos_observe.pex --http_port={{thermos.ports[http]}} --root=$HOME/.thermos'
src/main/python/apache/thermos/observer/bin/BUILD:  name = 'thermos_observer',
src/main/python/apache/thermos/observer/bin/BUILD:  source = 'thermos_observer.py',
src/main/python/apache/thermos/observer/bin/BUILD:  entry_point = 'apache.thermos.observer.bin.thermos_observer:proxy_main',
src/main/python/apache/thermos/observer/BUILD:    thermos_observer = pants('src/main/python/apache/thermos/observer/bin:thermos_observer'),


Diffs
-----

  src/main/python/apache/thermos/README.md 4bfefd37163dfbc5947acc7adc52f57c95cd174f 

Diff: https://reviews.apache.org/r/17293/diff/


Testing
-------

None, it's a document and it's out of date.


Thanks,

David Robinson