[jira] [Updated] (LUCENE-3998) facet module should have no dependencies, consolidate examples into demo/

["Shai Erera (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LUCENE-3998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shai Erera updated LUCENE-3998:
-------------------------------

    Attachment: LUCENE-3998.patch

* Patch moves all facet example code under demo/o.a.l.facet.*.

* Also removed the dependency on analyzers (there were few KeywordAnalyzer leftovers under facet tests).

* Ran facet + demo + benchmark tests -- all pass.

* Excluded demo/classes.../** from system-out checks (facet example code print messages, and in general demo/ should be allowed to print...)

* ant precommit passes.

I'd like to commit this soon.
                
> facet module should have no dependencies, consolidate examples into demo/
> -------------------------------------------------------------------------
>
>                 Key: LUCENE-3998
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3998
>             Project: Lucene - Core
>          Issue Type: Task
>          Components: modules/facet
>    Affects Versions: 4.0-ALPHA
>            Reporter: Robert Muir
>         Attachments: LUCENE-3998.patch, LUCENE-3998.patch
>
>
> currently facets depends on analyzers-common, but this is unnecessary.
> additionally it has a nice examples/ package (even with javadocs! are they actually seen anywhere?!),
> as well as tests for those examples.
> I think instead it would be better if facet/ had no dependencies,
> and if examples+examples tests were in demo/.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org