You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by we...@apache.org on 2024/04/12 14:37:31 UTC

(cloudstack) branch 4.19 updated: Fixup 4.19 build issue (#8905)

This is an automated email from the ASF dual-hosted git repository.

weizhou pushed a commit to branch 4.19
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.19 by this push:
     new 44aa08c02a3 Fixup 4.19 build issue (#8905)
44aa08c02a3 is described below

commit 44aa08c02a32cd7d899df0ffd8785f337ea9affd
Author: Vishesh <vi...@gmail.com>
AuthorDate: Fri Apr 12 20:07:25 2024 +0530

    Fixup 4.19 build issue (#8905)
---
 .../engine/orchestration/VolumeOrchestrator.java   | 26 ----------------------
 1 file changed, 26 deletions(-)

diff --git a/engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java b/engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
index 5c79fb64d8d..e49616d06ca 100644
--- a/engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
+++ b/engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
@@ -880,32 +880,6 @@ public class VolumeOrchestrator extends ManagerBase implements VolumeOrchestrati
         return diskProfile;
     }
 
-    @Override
-    public void saveVolumeDetails(Long diskOfferingId, Long volumeId) {
-        List<VolumeDetailVO> volumeDetailsVO = new ArrayList<>();
-        DiskOfferingDetailVO bandwidthLimitDetail = _diskOfferingDetailDao.findDetail(diskOfferingId, Volume.BANDWIDTH_LIMIT_IN_MBPS);
-        if (bandwidthLimitDetail != null) {
-            volumeDetailsVO.add(new VolumeDetailVO(volumeId, Volume.BANDWIDTH_LIMIT_IN_MBPS, bandwidthLimitDetail.getValue(), false));
-        } else {
-            VolumeDetailVO bandwidthLimit = _volDetailDao.findDetail(volumeId, Volume.BANDWIDTH_LIMIT_IN_MBPS);
-            if (bandwidthLimit != null) {
-                _volDetailDao.remove(bandwidthLimit.getId());
-            }
-        }
-        DiskOfferingDetailVO iopsLimitDetail = _diskOfferingDetailDao.findDetail(diskOfferingId, Volume.IOPS_LIMIT);
-        if (iopsLimitDetail != null) {
-            volumeDetailsVO.add(new VolumeDetailVO(volumeId, Volume.IOPS_LIMIT, iopsLimitDetail.getValue(), false));
-        } else {
-            VolumeDetailVO iopsLimit = _volDetailDao.findDetail(volumeId, Volume.IOPS_LIMIT);
-            if (iopsLimit != null) {
-                _volDetailDao.remove(iopsLimit.getId());
-            }
-        }
-        if (!volumeDetailsVO.isEmpty()) {
-            _volDetailDao.saveDetails(volumeDetailsVO);
-        }
-    }
-
     private DiskProfile allocateTemplatedVolume(Type type, String name, DiskOffering offering, Long rootDisksize, Long minIops, Long maxIops, VirtualMachineTemplate template, VirtualMachine vm,
                                                 Account owner, long deviceId, String configurationId) {
         assert (template.getFormat() != ImageFormat.ISO) : "ISO is not a template.";