You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/02/14 19:31:42 UTC

[jira] [Commented] (FLINK-5798) Let the RPCService provide a ScheduledExecutorService

    [ https://issues.apache.org/jira/browse/FLINK-5798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866450#comment-15866450 ] 

ASF GitHub Bot commented on FLINK-5798:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/3310

    [FLINK-5798] [rpc] Let the RpcService provide a ScheduledExecutorService

    This PR adds the getScheduledExecutorService method to the RpcService interface. So
    henceforth all RpcService implementations have to provide a ScheduledExecutorService
    implementation.
    
    Currently, we only support the AkkaRpcService. The AkkaRpcService returns a
    ScheduledExecutorService proxy which forwards the schedule calls to the ActorSystem's
    internal scheduler.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink rpcAddScheduledExecutorService

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3310.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3310
    
----
commit 639edf235ffee924e0fba56313cb51f825e3a46d
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-02-14T15:50:43Z

    [FLINK-5798] [rpc] Let the RpcService provide a ScheduledExecutorService
    
    This PR adds the getScheduledExecutorService method to the RpcService interface. So
    henceforth all RpcService implementations have to provide a ScheduledExecutorService
    implementation.
    
    Currently, we only support the AkkaRpcService. The AkkaRpcService returns a
    ScheduledExecutorService proxy which forwards the schedule calls to the ActorSystem's
    internal scheduler.

----


> Let the RPCService provide a ScheduledExecutorService
> -----------------------------------------------------
>
>                 Key: FLINK-5798
>                 URL: https://issues.apache.org/jira/browse/FLINK-5798
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>    Affects Versions: 1.3.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>             Fix For: 1.3.0
>
>
> Currently the {{RPCService}} interface provides a {{scheduleRunnable}} method to schedule {{Runnables}}. I would like to generalize this functionality by letting the {{RPCService}} provide a {{ScheduledExecutorService}} to the user. That way other components which require such an executor service could simply use the one provided by the {{RPCService}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)