You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Kirk Lund <ki...@gmail.com> on 2016/05/04 23:03:08 UTC
Review Request 46915: Add test coverage for using a custom log4j2.xml
with Geode
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46915/
-----------------------------------------------------------
Review request for geode, Jens Deppe, Jinmei Liao, Kirk Lund, and William Markito.
Bugs: GEODE-1255
https://issues.apache.org/jira/browse/GEODE-1255
Repository: geode
Description
-------
GEODE-1255: Add test coverage for using a custom log4j2.xml with Geode
* refactor launcher integration tests (rename files, use TemporaryFolder)
* refactor cluster config tests (use TemporaryFolder)
* change several additional tests to use TemporaryFolder
* add better support for TemporaryFolder usage to HeadlessGfsh
* alter HeadlessGfsh tests to use TemporaryFolder
* rescope variables and methods to private where possible
* fixup file formatting
* prevent eating of exceptions
* remove incomplete or useless javadocs
* rename LocatorJUnitTest test methods from TRAC #s to meaningful names
Diffs
-----
geode-assembly/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherAssemblyIntegrationTest.java PRE-CREATION
geode-assembly/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherAssemblyJUnitTest.java 0984508
geode-assembly/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java 653bbdc
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/OperationContext.java b632edb
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/SharedConfiguration.java 8f190eb
geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLauncherIntegrationJUnitTest.java 745090d
geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLauncherIntegrationTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLauncherIntegrationTestCase.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLauncherJUnitTest.java f5867d4
geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLauncherJUnitTestCase.java 77961e0
geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLauncherServiceStatusJUnitTest.java ca24a4e
geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLauncherServiceStatusTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLauncherTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLocatorLauncherIntegrationTestCase.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLocatorLauncherJUnitTestCase.java 62c4d86
geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLocatorLauncherRemoteIntegrationTestCase.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractServerLauncherIntegrationTestCase.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractServerLauncherJUnitTestCase.java 0ee3e7c
geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractServerLauncherRemoteIntegrationTestCase.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/distributed/DistributedTestSuite.java 58b8d2a
geode-core/src/test/java/com/gemstone/gemfire/distributed/HostedLocatorsDUnitTest.java a5b07ee
geode-core/src/test/java/com/gemstone/gemfire/distributed/LauncherMemberMXBeanIntegrationTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/distributed/LauncherMemberMXBeanJUnitTest.java 30e21e1
geode-core/src/test/java/com/gemstone/gemfire/distributed/LauncherTestSuite.java b5e787a
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorJUnitTest.java 3c80d9a
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherIntegrationJUnitTest.java 3b56554
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherIntegrationTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherJUnitTest.java a8ddd6a
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherLocalFileIntegrationTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherLocalFileJUnitTest.java 7dc5452
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherLocalIntegrationTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherLocalJUnitTest.java bfed4d0
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteFileIntegrationTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteFileJUnitTest.java d3edcae
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteIntegrationTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteJUnitTest.java 63c7c74
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteWithCustomLoggingIntegrationTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorStateJUnitTest.java 248c39f
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorStateTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/distributed/MockServerLauncherCacheProvider.java c910832
geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherIntegrationJUnitTest.java b61f89d
geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherIntegrationTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherJUnitTest.java 395a9e6
geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherLocalFileIntegrationTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherLocalFileJUnitTest.java bda05c4
geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherLocalIntegrationTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherLocalJUnitTest.java fd7d806
geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherRemoteFileIntegrationTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherRemoteFileJUnitTest.java d8e318f
geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherRemoteIntegrationTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherRemoteJUnitTest.java 056e6ce
geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherRemoteWithCustomLoggingIntegrationTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherWithProviderIntegrationTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherWithProviderJUnitTest.java 9728485
geode-core/src/test/java/com/gemstone/gemfire/internal/ClassBuilder.java 780ed4f
geode-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/custom/BasicAppender.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/custom/CustomConfigWithCacheIntegrationTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/custom/CustomConfigWithLogServiceIntegrationTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/custom/CustomConfiguration.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/internal/process/FileProcessControllerIntegrationJUnitTest.java 6255af1
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/HeadlessGfsh.java 156a198
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/HeadlessGfshIntegrationTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/HeadlessGfshJUnitTest.java 86fe03e
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java f2dc80f
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ConnectCommandWithHttpAndSSLDUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DeployCommandsDUnitTest.java e4b50b9
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GetCommandOnRegionWithCacheLoaderDuringCacheMissDUnitTest.java 55ef25c
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListAndDescribeDiskStoreCommandsDUnitTest.java bb46b75
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListIndexCommandDUnitTest.java 97ca98a
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/SharedConfigurationCommandsDUnitTest.java d871062
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommandsDUnitTest.java d4fe871
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/UserCommandsDUnitTest.java 9f44c14
geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationDUnitTest.java 92fe1bc
geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationTestUtils.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationUsingDirDUnitTest.java 70f3e70
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GfshShellConnectionRule.java 17549d5
geode-core/src/test/resources/com/gemstone/gemfire/internal/logging/log4j/custom/log4j2-custom.xml PRE-CREATION
geode-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/data/JMXDataUpdater.java 47ff69e
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WANCommandTestBase.java 49a978c
geode-wan/src/test/java/com/gemstone/gemfire/management/internal/configuration/ClusterConfigurationDUnitTest.java 4ff9a73
gradle/dependency-versions.properties b3e004e
Diff: https://reviews.apache.org/r/46915/diff/
Testing
-------
precheckin
Thanks,
Kirk Lund
Re: Review Request 46915: Add test coverage for using a custom
log4j2.xml with Geode
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46915/#review131876
-----------------------------------------------------------
Ship it!
Ship It!
- Jens Deppe
On May 4, 2016, 11:03 p.m., Kirk Lund wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46915/
> -----------------------------------------------------------
>
> (Updated May 4, 2016, 11:03 p.m.)
>
>
> Review request for geode, Jens Deppe, Jinmei Liao, Kirk Lund, and William Markito.
>
>
> Bugs: GEODE-1255
> https://issues.apache.org/jira/browse/GEODE-1255
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1255: Add test coverage for using a custom log4j2.xml with Geode
>
> * refactor launcher integration tests (rename files, use TemporaryFolder)
> * refactor cluster config tests (use TemporaryFolder)
> * change several additional tests to use TemporaryFolder
> * add better support for TemporaryFolder usage to HeadlessGfsh
> * alter HeadlessGfsh tests to use TemporaryFolder
> * rescope variables and methods to private where possible
> * fixup file formatting
> * prevent eating of exceptions
> * remove incomplete or useless javadocs
> * rename LocatorJUnitTest test methods from TRAC #s to meaningful names
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherAssemblyIntegrationTest.java PRE-CREATION
> geode-assembly/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherAssemblyJUnitTest.java 0984508
> geode-assembly/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java 653bbdc
> geode-core/src/main/java/com/gemstone/gemfire/cache/operations/OperationContext.java b632edb
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/SharedConfiguration.java 8f190eb
> geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLauncherIntegrationJUnitTest.java 745090d
> geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLauncherIntegrationTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLauncherIntegrationTestCase.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLauncherJUnitTest.java f5867d4
> geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLauncherJUnitTestCase.java 77961e0
> geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLauncherServiceStatusJUnitTest.java ca24a4e
> geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLauncherServiceStatusTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLauncherTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLocatorLauncherIntegrationTestCase.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLocatorLauncherJUnitTestCase.java 62c4d86
> geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLocatorLauncherRemoteIntegrationTestCase.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractServerLauncherIntegrationTestCase.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractServerLauncherJUnitTestCase.java 0ee3e7c
> geode-core/src/test/java/com/gemstone/gemfire/distributed/AbstractServerLauncherRemoteIntegrationTestCase.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/distributed/DistributedTestSuite.java 58b8d2a
> geode-core/src/test/java/com/gemstone/gemfire/distributed/HostedLocatorsDUnitTest.java a5b07ee
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LauncherMemberMXBeanIntegrationTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LauncherMemberMXBeanJUnitTest.java 30e21e1
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LauncherTestSuite.java b5e787a
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorJUnitTest.java 3c80d9a
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherIntegrationJUnitTest.java 3b56554
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherIntegrationTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherJUnitTest.java a8ddd6a
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherLocalFileIntegrationTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherLocalFileJUnitTest.java 7dc5452
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherLocalIntegrationTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherLocalJUnitTest.java bfed4d0
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteFileIntegrationTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteFileJUnitTest.java d3edcae
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteIntegrationTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteJUnitTest.java 63c7c74
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteWithCustomLoggingIntegrationTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorStateJUnitTest.java 248c39f
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorStateTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/distributed/MockServerLauncherCacheProvider.java c910832
> geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherIntegrationJUnitTest.java b61f89d
> geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherIntegrationTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherJUnitTest.java 395a9e6
> geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherLocalFileIntegrationTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherLocalFileJUnitTest.java bda05c4
> geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherLocalIntegrationTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherLocalJUnitTest.java fd7d806
> geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherRemoteFileIntegrationTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherRemoteFileJUnitTest.java d8e318f
> geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherRemoteIntegrationTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherRemoteJUnitTest.java 056e6ce
> geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherRemoteWithCustomLoggingIntegrationTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherWithProviderIntegrationTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherWithProviderJUnitTest.java 9728485
> geode-core/src/test/java/com/gemstone/gemfire/internal/ClassBuilder.java 780ed4f
> geode-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/custom/BasicAppender.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/custom/CustomConfigWithCacheIntegrationTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/custom/CustomConfigWithLogServiceIntegrationTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/custom/CustomConfiguration.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/internal/process/FileProcessControllerIntegrationJUnitTest.java 6255af1
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/HeadlessGfsh.java 156a198
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/HeadlessGfshIntegrationTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/HeadlessGfshJUnitTest.java 86fe03e
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java f2dc80f
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ConnectCommandWithHttpAndSSLDUnitTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DeployCommandsDUnitTest.java e4b50b9
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GetCommandOnRegionWithCacheLoaderDuringCacheMissDUnitTest.java 55ef25c
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListAndDescribeDiskStoreCommandsDUnitTest.java bb46b75
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ListIndexCommandDUnitTest.java 97ca98a
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/SharedConfigurationCommandsDUnitTest.java d871062
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommandsDUnitTest.java d4fe871
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/UserCommandsDUnitTest.java 9f44c14
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationDUnitTest.java 92fe1bc
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationTestUtils.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationUsingDirDUnitTest.java 70f3e70
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GfshShellConnectionRule.java 17549d5
> geode-core/src/test/resources/com/gemstone/gemfire/internal/logging/log4j/custom/log4j2-custom.xml PRE-CREATION
> geode-pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/data/JMXDataUpdater.java 47ff69e
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/wancommand/WANCommandTestBase.java 49a978c
> geode-wan/src/test/java/com/gemstone/gemfire/management/internal/configuration/ClusterConfigurationDUnitTest.java 4ff9a73
> gradle/dependency-versions.properties b3e004e
>
> Diff: https://reviews.apache.org/r/46915/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Kirk Lund
>
>