[GitHub] spark pull request #22177: [SPARK-25119][Web UI] stages in wrong order withi...

[vanzin <gi...@git.apache.org>]

Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22177#discussion_r212134537
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobPage.scala ---
    @@ -337,7 +337,9 @@ private[ui] class JobPage(parent: JobsTab, store: AppStatusStore) extends WebUIP
           store.executorList(false), appStartTime)
     
         val operationGraphContent = store.asOption(store.operationGraphForJob(jobId)) match {
    -      case Some(operationGraph) => UIUtils.showDagVizForJob(jobId, operationGraph)
    +      case Some(operationGraph) => UIUtils.showDagVizForJob(jobId, operationGraph.sortWith(
    +        _.rootCluster.id.replaceAll(RDDOperationGraph.STAGE_CLUSTER_PREFIX, "").toInt
    --- End diff --
    
    +1. `replaceAll` also seems like the wrong API to use, `substring` seems more correct.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org