You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/02/18 11:15:20 UTC

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9120: Add feature flags to control query sharing, KV exposure

dpgaspar commented on a change in pull request #9120: Add feature flags to control query sharing, KV exposure
URL: https://github.com/apache/incubator-superset/pull/9120#discussion_r380608751
 
 

 ##########
 File path: tests/core_tests.py
 ##########
 @@ -497,6 +504,9 @@ def test_shortner(self):
         resp = self.client.post("/r/shortner/", data=dict(data=data))
         assert re.search(r"\/r\/[0-9]+", resp.data.decode("utf-8"))
 
+    @skipUnless(
 
 Review comment:
   Could enabling this feature on just for the tests be a viable approach? `superset_test_config.py`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org