You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/03/24 17:44:30 UTC
[GitHub] [solr] cpoerschke commented on a change in pull request #759: SOLR-16114 Remove SolrZookeeper
cpoerschke commented on a change in pull request #759:
URL: https://github.com/apache/solr/pull/759#discussion_r834516072
##########
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##########
@@ -1886,7 +1886,7 @@ public void reload(String name, UUID coreId) {
if (docCollection != null) {
Replica replica = docCollection.getReplica(cd.getCloudDescriptor().getCoreNodeName());
- assert replica != null;
+ assert replica != null : cd.getCloudDescriptor().getCoreNodeName() + " had no replica";
Review comment:
minor: minor unrelated change?
##########
File path: solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
##########
@@ -300,6 +301,7 @@ public static void setupTestCases() {
System.setProperty("solr.v2RealPath", "true");
System.setProperty("zookeeper.forceSync", "no");
System.setProperty("jetty.testMode", "true");
+ System.setProperty("solr.zookeeper.connectionStrategy", TestConnectionStrategy.class.getName());
Review comment:
Could we have a comment here re: how or where it is used?
##########
File path: solr/core/src/test/org/apache/solr/cloud/DistributedQueueTest.java
##########
@@ -299,7 +299,7 @@ private void forceSessionExpire() throws InterruptedException, TimeoutException
Thread.sleep(50);
}
assertTrue(zkClient.isConnected());
- assertFalse(sessionId == zkClient.getSolrZooKeeper().getSessionId());
+ assertFalse(sessionId == zkClient.getZooKeeper().getSessionId());
Review comment:
pre-existing
```suggestion
assertNotEquals(sessionId, zkClient.getZooKeeper().getSessionId());
```
##########
File path: solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java
##########
@@ -791,14 +791,13 @@ public JettySolrRunner getReplicaJetty(Replica replica) {
/** Make the zookeeper session on a particular jetty expire */
public void expireZkSession(JettySolrRunner jetty) {
+ ChaosMonkey.causeConnectionLoss(jetty);
+
Review comment:
Am curious about (not) keeping the connection loss/close within the `cores != null` conditional before the session expiry.
##########
File path: solr/licenses/zookeeper-3.7.0-tests.jar.sha1
##########
@@ -0,0 +1 @@
+093f2c34c33ee16f9ff3f9352c79eafd3cd9040a
Review comment:
dumb question: how to cross-check the sha1 value here? i couldn't find a `zookeeper-3.7.0-tests.jar` within http://archive.apache.org/dist/zookeeper/zookeeper-3.7.0/ say?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org