You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by mureinik <gi...@git.apache.org> on 2018/10/02 04:20:00 UTC

[GitHub] commons-lang pull request #363: Update builder tests to JUnit Jupiter

GitHub user mureinik opened a pull request:

    https://github.com/apache/commons-lang/pull/363

    Update builder tests to JUnit Jupiter

    Upgrade the tests in the builder package to use JUnit Jupiter as part of the effort to remove the dependency on the Vintage Engine.
    
    While most of these changes are drop-in replacements with no functional benefit, it is worth mentioning the change to how expected exceptions are tested.
    Unlike `org.junit.Test`, `org.junit.jupiter.api.Test` does not have an `expected` argument. Instead, an explicit call to `org.junit.jupiter.api.Assertions.assertThrows` is used. This call allows the test to pinpoint the exact statement that is expected to throw the exception and allows making the tests a bit stricter by preventing
    false-positives that could occur if the setup code would throw the expected exception instead of the statement that was supposed to throw it.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mureinik/commons-lang junit-jupiter

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/363.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #363
    
----
commit 0c320dfc356b78145107a4b121d674dbccb84437
Author: Allon Mureinik <mu...@...>
Date:   2018-10-02T03:41:37Z

    Update builder tests to JUnit Jupiter
    
    Upgrade the tests in the builder package to use JUnit Jupiter as part of
    the effort to remove the dependency on the Vintage Engine.
    
    While most of these changes are drop-in replacements with no functional
    benefit, it is worth mentioning the change to how expected exceptions
    are tested.
    Unlike org.junit.Test, org.junit.jupiter.api.Test does not have an
    "expected" argument. Instead, an explicit call to
    org.junit.jupiter.api.Assertions.assertThrows is used. This call allows
    the test to pinpoint the exact statement that is expected to throw the
    expcetion and allows making the tests a bit stricter by preventing
    false-positives that could occur if the setup code would throw the
    expected exception instead of the statement that was supposed to throw
    it.

----


---

[GitHub] commons-lang issue #363: Update builder tests to JUnit Jupiter

Posted by PascalSchumacher <gi...@git.apache.org>.

Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-lang/pull/363
  
    Thanks! 👍 
    
    Merged in https://github.com/apache/commons-lang/commit/729adb624d3e720afb8686093814ab2bcc2d2f13
    
    Not sure why this pull request was not auto-closed even-though I fast-forward merged the branch.
    
    Could you please close the pull request?
    
    Thanks!


---

[GitHub] commons-lang pull request #363: Update builder tests to JUnit Jupiter

Posted by mureinik <gi...@git.apache.org>.

Github user mureinik closed the pull request at:

    https://github.com/apache/commons-lang/pull/363


---

[GitHub] commons-lang issue #363: Update builder tests to JUnit Jupiter

Posted by coveralls <gi...@git.apache.org>.

Github user coveralls commented on the issue:

    https://github.com/apache/commons-lang/pull/363
  
    
    [![Coverage Status](https://coveralls.io/builds/19295739/badge)](https://coveralls.io/builds/19295739)
    
    Coverage remained the same at 95.253% when pulling **0c320dfc356b78145107a4b121d674dbccb84437 on mureinik:junit-jupiter** into **69e843890c09861a168c6fe77d63fc72f0c73195 on apache:master**.



---

[GitHub] commons-lang issue #363: Update builder tests to JUnit Jupiter

Posted by mureinik <gi...@git.apache.org>.

Github user mureinik commented on the issue:

    https://github.com/apache/commons-lang/pull/363
  
    > Thanks! 👍
    > 
    > Merged in [729adb6](https://github.com/apache/commons-lang/commit/729adb624d3e720afb8686093814ab2bcc2d2f13)
    > 
    > Not sure why this pull request was not auto-closed even-though I fast-forward merged the branch.
    > 
    > Could you please close the pull request?
    > 
    > Thanks!
    
    Closing, thanks @PascalSchumacher 


---