You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ma...@apache.org on 2019/03/30 18:46:03 UTC
[incubator-superset] branch master updated: [SQL Lab] Show tooltip
on schema and table select options (#7120)
This is an automated email from the ASF dual-hosted git repository.
maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new 03c95c8 [SQL Lab] Show tooltip on schema and table select options (#7120)
03c95c8 is described below
commit 03c95c86ddac7f7210df178ff20c2b6369875298
Author: Enrico Berti <he...@enricoberti.com>
AuthorDate: Sat Mar 30 19:45:53 2019 +0100
[SQL Lab] Show tooltip on schema and table select options (#7120)
Closes #7119
---
superset/assets/src/components/TableSelector.jsx | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/superset/assets/src/components/TableSelector.jsx b/superset/assets/src/components/TableSelector.jsx
index 0452854..c3e405e 100644
--- a/superset/assets/src/components/TableSelector.jsx
+++ b/superset/assets/src/components/TableSelector.jsx
@@ -130,7 +130,11 @@ export default class TableSelector extends React.PureComponent {
this.setState(() => ({
filterOptions,
tableLoading: false,
- tableOptions: json.options,
+ tableOptions: json.options.map(o => ({
+ value: o.value,
+ label: o.label,
+ title: o.label,
+ })),
}));
})
.catch(() => {
@@ -150,7 +154,7 @@ export default class TableSelector extends React.PureComponent {
return SupersetClient.get({ endpoint })
.then(({ json }) => {
- const schemaOptions = json.schemas.map(s => ({ value: s, label: s }));
+ const schemaOptions = json.schemas.map(s => ({ value: s, label: s, title: s }));
this.setState({ schemaOptions, schemaLoading: false });
})
.catch(() => {