You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Bernd Mathiske <be...@mesosphere.io> on 2014/02/24 16:49:01 UTC
Review Request 18425: Fixed MESOS-1029: Compile errors in lib stout when
using Clang 3.5 on Ubuntu 13.10
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18425/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-1029
https://issues.apache.org/jira/browse/MESOS-1029
Repository: mesos-git
Description
-------
Compile errors in lib stout when using Clang 3.5 on Ubuntu 13.10.
Originally reported as additional fix for MESOS-1009, now separated.
../../3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp:730:18: error: 'va_start' has undefined behavior with
reference types [-Werror,-Wvarargs]
va_start(args, fmt);
^
/root/clang/build/Release/bin/../lib/clang/3.5/include/stdarg.h:33:52: note: expanded from macro 'va_start'
#define va_start(ap, param) __builtin_va_start(ap, param)
^
../../3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp:727:60: note: parameter of type 'const std::string &'
(aka 'const basic_string<char> &') is declared here
inline Try<int> shell(std::ostream* os, const std::string& fmt, ...)
../../3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp:402:18: error: 'va_start' has undefined behavior with
reference types [-Werror,-Wvarargs]
va_start(args, fmt);
^
/root/clang/build/Release/bin/../lib/clang/3.5/include/stdarg.h:33:52: note: expanded from macro 'va_start'
#define va_start(ap, param) __builtin_va_start(ap, param)
^
../../3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp:399:51: note: parameter of type 'const std::string &'
(aka 'const basic_string<char> &') is declared here
inline Try<std::string> format(const std::string& fmt, ...)
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 3eadaef
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp bba6f43
Diff: https://reviews.apache.org/r/18425/diff/
Testing
-------
make progresses as expected on Ubuntu 13.10 with Clang 3.5 and still succeeds completely on Mac OS X 10.9 with gcc4.8.1 and clang. Local Mesos and frameworks run on Mac when all compile errors fixed (one more MESOS issue to be filed for that...).
Thanks,
Bernd Mathiske
Re: Review Request 18425: Fixed MESOS-1029: Compile errors in lib stout when
using Clang 3.5 on Ubuntu 13.10
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18425/#review35652
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 27, 2014, 6:16 p.m., Bernd Mathiske wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18425/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2014, 6:16 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1029
> https://issues.apache.org/jira/browse/MESOS-1029
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Compile errors in lib stout when using Clang 3.5 on Ubuntu 13.10.
> Originally reported as additional fix for MESOS-1009, now separated.
>
> ../../3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp:730:18: error: 'va_start' has undefined behavior with
> reference types [-Werror,-Wvarargs]
> va_start(args, fmt);
> ^
> /root/clang/build/Release/bin/../lib/clang/3.5/include/stdarg.h:33:52: note: expanded from macro 'va_start'
> #define va_start(ap, param) __builtin_va_start(ap, param)
> ^
> ../../3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp:727:60: note: parameter of type 'const std::string &'
> (aka 'const basic_string<char> &') is declared here
> inline Try<int> shell(std::ostream* os, const std::string& fmt, ...)
>
>
> ../../3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp:402:18: error: 'va_start' has undefined behavior with
> reference types [-Werror,-Wvarargs]
> va_start(args, fmt);
> ^
> /root/clang/build/Release/bin/../lib/clang/3.5/include/stdarg.h:33:52: note: expanded from macro 'va_start'
> #define va_start(ap, param) __builtin_va_start(ap, param)
> ^
> ../../3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp:399:51: note: parameter of type 'const std::string &'
> (aka 'const basic_string<char> &') is declared here
> inline Try<std::string> format(const std::string& fmt, ...)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 3eadaef
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp bba6f43
>
> Diff: https://reviews.apache.org/r/18425/diff/
>
>
> Testing
> -------
>
> make progresses as expected on Ubuntu 13.10 with Clang 3.5 and still succeeds completely on Mac OS X 10.9 with gcc4.8.1 and clang. Local Mesos and frameworks run on Mac when all compile errors fixed (one more MESOS issue to be filed for that...).
>
>
> Thanks,
>
> Bernd Mathiske
>
>
Re: Review Request 18425: Fixed MESOS-1029: Compile errors in lib stout when
using Clang 3.5 on Ubuntu 13.10
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18425/
-----------------------------------------------------------
(Updated Feb. 27, 2014, 6:16 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
assigning to @vinodkone for review.
Bugs: MESOS-1029
https://issues.apache.org/jira/browse/MESOS-1029
Repository: mesos-git
Description
-------
Compile errors in lib stout when using Clang 3.5 on Ubuntu 13.10.
Originally reported as additional fix for MESOS-1009, now separated.
../../3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp:730:18: error: 'va_start' has undefined behavior with
reference types [-Werror,-Wvarargs]
va_start(args, fmt);
^
/root/clang/build/Release/bin/../lib/clang/3.5/include/stdarg.h:33:52: note: expanded from macro 'va_start'
#define va_start(ap, param) __builtin_va_start(ap, param)
^
../../3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp:727:60: note: parameter of type 'const std::string &'
(aka 'const basic_string<char> &') is declared here
inline Try<int> shell(std::ostream* os, const std::string& fmt, ...)
../../3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp:402:18: error: 'va_start' has undefined behavior with
reference types [-Werror,-Wvarargs]
va_start(args, fmt);
^
/root/clang/build/Release/bin/../lib/clang/3.5/include/stdarg.h:33:52: note: expanded from macro 'va_start'
#define va_start(ap, param) __builtin_va_start(ap, param)
^
../../3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp:399:51: note: parameter of type 'const std::string &'
(aka 'const basic_string<char> &') is declared here
inline Try<std::string> format(const std::string& fmt, ...)
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 3eadaef
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp bba6f43
Diff: https://reviews.apache.org/r/18425/diff/
Testing
-------
make progresses as expected on Ubuntu 13.10 with Clang 3.5 and still succeeds completely on Mac OS X 10.9 with gcc4.8.1 and clang. Local Mesos and frameworks run on Mac when all compile errors fixed (one more MESOS issue to be filed for that...).
Thanks,
Bernd Mathiske
Re: Review Request 18425: Fixed MESOS-1029: Compile errors in lib stout when
using Clang 3.5 on Ubuntu 13.10
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18425/#review35647
-----------------------------------------------------------
Ship it!
Ship It!
- Dominic Hamon
On Feb. 24, 2014, 7:49 a.m., Bernd Mathiske wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18425/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2014, 7:49 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1029
> https://issues.apache.org/jira/browse/MESOS-1029
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Compile errors in lib stout when using Clang 3.5 on Ubuntu 13.10.
> Originally reported as additional fix for MESOS-1009, now separated.
>
> ../../3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp:730:18: error: 'va_start' has undefined behavior with
> reference types [-Werror,-Wvarargs]
> va_start(args, fmt);
> ^
> /root/clang/build/Release/bin/../lib/clang/3.5/include/stdarg.h:33:52: note: expanded from macro 'va_start'
> #define va_start(ap, param) __builtin_va_start(ap, param)
> ^
> ../../3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp:727:60: note: parameter of type 'const std::string &'
> (aka 'const basic_string<char> &') is declared here
> inline Try<int> shell(std::ostream* os, const std::string& fmt, ...)
>
>
> ../../3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp:402:18: error: 'va_start' has undefined behavior with
> reference types [-Werror,-Wvarargs]
> va_start(args, fmt);
> ^
> /root/clang/build/Release/bin/../lib/clang/3.5/include/stdarg.h:33:52: note: expanded from macro 'va_start'
> #define va_start(ap, param) __builtin_va_start(ap, param)
> ^
> ../../3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp:399:51: note: parameter of type 'const std::string &'
> (aka 'const basic_string<char> &') is declared here
> inline Try<std::string> format(const std::string& fmt, ...)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 3eadaef
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp bba6f43
>
> Diff: https://reviews.apache.org/r/18425/diff/
>
>
> Testing
> -------
>
> make progresses as expected on Ubuntu 13.10 with Clang 3.5 and still succeeds completely on Mac OS X 10.9 with gcc4.8.1 and clang. Local Mesos and frameworks run on Mac when all compile errors fixed (one more MESOS issue to be filed for that...).
>
>
> Thanks,
>
> Bernd Mathiske
>
>