You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2018/05/09 11:42:35 UTC
[GitHub] flink pull request #5972: [FLINK-9323][build] Properly organize checkstyle-p...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5972
[FLINK-9323][build] Properly organize checkstyle-plugin configuration
## What is the purpose of the change
This PR reorganizes the checkstyle-plugin configuration to not be duplicated in 4 modules. Instead the configuration was moved into the root pluginManagement section. The child poms were adjusted to only override settings if required.
## Brief change log
* move checkstyle configuration into root pluginManagement section
* reduce child pom configuration to essential entry
## Verifying this change
* run `mvn help:effective-pom` to verify that the effective poms have not changed, and that the suppression file is properly overridden
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 9323
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5972.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5972
----
commit 7ac435e9240d14d6f264bdba205adfd6394005f3
Author: zentol <ch...@...>
Date: 2018-05-09T11:20:41Z
[FLINK-9323][build] Properly organize checkstyle-plugin configuration
----
---
[GitHub] flink pull request #5972: [FLINK-9323][build] Properly organize checkstyle-p...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5972
---
[GitHub] flink issue #5972: [FLINK-9323][build] Properly organize checkstyle-plugin c...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5972
the build failed because of a copy&paste error, flink-core and flink-optimizer are using the flink-runtime suppressions file...
---
[GitHub] flink issue #5972: [FLINK-9323][build] Properly organize checkstyle-plugin c...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5972
+1 to the cleanup, but I think this might be breaking relative paths of the suppression files, hence causing the build to fail. Probably need to make the paths relative to "root dir" or some "highest project dir" variable.
---