[GitHub] [flink] zhuzhurk opened a new pull request #10341: [FLINK-14974][runtime] Calculate managed memory fractions with BigDecimal and round down it properly

[GitBox <gi...@apache.org>]

zhuzhurk opened a new pull request #10341: [FLINK-14974][runtime] Calculate managed memory fractions with BigDecimal and round down it properly
URL: https://github.com/apache/flink/pull/10341
 
 
   
   ## What is the purpose of the change
   
   This PR is to change `StreamingJobGraphGenerator#setManagedMemoryFractionForOperator` to use `BigDecimal#divide(otherValue, scale, RoundMode.ROUND_DOWN)` to calculate managed memory fractions. In this way, the sum of the fractions will not exceed 1.0. 
   Otherwise fractions summed up to be more than 1.0 may result in the last operator to fail to allocate managed memory it is supposed to be able to acquire.
   
   ## Brief change log
   
     - *Changed `StreamingJobGraphGenerator#setManagedMemoryFractionForOperator` to use `BigDecimal#divide(otherValue, scale, RoundMode.ROUND_DOWN)` to calculate managed memory fractions*
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - *The case StreamingJobGraphGeneratorTest#testManagedMemoryFractionForSpecifiedResourceSpec is adjusted to verify this change*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services