You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cactus-dev@jakarta.apache.org by "Brett Porter (JIRA)" <ca...@jakarta.apache.org> on 2004/12/10 07:11:12 UTC

[jira] Created: (CACTUS-161) maven.compile.[target|source] usage incorrect

maven.compile.[target|source] usage incorrect
---------------------------------------------

         Key: CACTUS-161
         URL: http://nagoya.apache.org/jira/browse/CACTUS-161
     Project: Cactus
        Type: Bug
  Components: Maven Integration  
    Versions: 1.7    
    Reporter: Brett Porter
    Priority: Blocker


in cactus:compile,

use of target="...maven.compile.target..." is incorrect, as maven.compile.target can be empty, and is by default in Maven 1.0.2.

Instead, should conditionally use <setproperty />, as is done for maven.compile.source later.

Also, source is now duplicated by the source="..." parameter to javac. It should be removed, and rely on the later property setting.

Let me know if this isn't clear, I'll do a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org


[jira] Updated: (CACTUS-161) maven.compile.[target|source] usage incorrect

Posted by "Brett Porter (JIRA)" <ca...@jakarta.apache.org>.
     [ http://nagoya.apache.org/jira/browse/CACTUS-161?page=history ]

Brett Porter updated CACTUS-161:
--------------------------------

    Attachment: CACTUS-161.diff

patch

> maven.compile.[target|source] usage incorrect
> ---------------------------------------------
>
>          Key: CACTUS-161
>          URL: http://nagoya.apache.org/jira/browse/CACTUS-161
>      Project: Cactus
>         Type: Bug
>   Components: Maven Integration
>     Versions: 1.7
>     Reporter: Brett Porter
>     Priority: Blocker
>  Attachments: CACTUS-161.diff
>
> in cactus:compile,
> use of target="...maven.compile.target..." is incorrect, as maven.compile.target can be empty, and is by default in Maven 1.0.2.
> Instead, should conditionally use <setproperty />, as is done for maven.compile.source later.
> Also, source is now duplicated by the source="..." parameter to javac. It should be removed, and rely on the later property setting.
> Let me know if this isn't clear, I'll do a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org


[jira] Commented: (CACTUS-161) maven.compile.[target|source] usage incorrect

Posted by "Felipe Leme (JIRA)" <ca...@jakarta.apache.org>.
     [ http://nagoya.apache.org/jira/browse/CACTUS-161?page=comments#action_56499 ]
     
Felipe Leme commented on CACTUS-161:
------------------------------------

It's clear, but a patch would be very welcome anyways :-)

> maven.compile.[target|source] usage incorrect
> ---------------------------------------------
>
>          Key: CACTUS-161
>          URL: http://nagoya.apache.org/jira/browse/CACTUS-161
>      Project: Cactus
>         Type: Bug
>   Components: Maven Integration
>     Versions: 1.7
>     Reporter: Brett Porter
>     Priority: Blocker

>
> in cactus:compile,
> use of target="...maven.compile.target..." is incorrect, as maven.compile.target can be empty, and is by default in Maven 1.0.2.
> Instead, should conditionally use <setproperty />, as is done for maven.compile.source later.
> Also, source is now duplicated by the source="..." parameter to javac. It should be removed, and rely on the later property setting.
> Let me know if this isn't clear, I'll do a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org


[jira] Closed: (CACTUS-161) maven.compile.[target|source] usage incorrect

Posted by "Felipe Leme (JIRA)" <ca...@jakarta.apache.org>.
     [ http://nagoya.apache.org/jira/browse/CACTUS-161?page=history ]
     
Felipe Leme closed CACTUS-161:
------------------------------

      Assign To: Felipe Leme
     Resolution: Fixed
    Fix Version: 1.7

Applied, thanks...

> maven.compile.[target|source] usage incorrect
> ---------------------------------------------
>
>          Key: CACTUS-161
>          URL: http://nagoya.apache.org/jira/browse/CACTUS-161
>      Project: Cactus
>         Type: Bug
>   Components: Maven Integration
>     Versions: 1.7
>     Reporter: Brett Porter
>     Assignee: Felipe Leme
>     Priority: Blocker
>      Fix For: 1.7
>  Attachments: CACTUS-161.diff
>
> in cactus:compile,
> use of target="...maven.compile.target..." is incorrect, as maven.compile.target can be empty, and is by default in Maven 1.0.2.
> Instead, should conditionally use <setproperty />, as is done for maven.compile.source later.
> Also, source is now duplicated by the source="..." parameter to javac. It should be removed, and rely on the later property setting.
> Let me know if this isn't clear, I'll do a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org