You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Avinash sridharan <av...@mesosphere.io> on 2017/06/11 01:16:34 UTC
Re: Review Request 59721: Refactored net::IP and added net::IPv4 and
net::IPv6.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59721/
-----------------------------------------------------------
(Updated June 11, 2017, 1:16 a.m.)
Review request for mesos, Benjamin Hindman and Jie Yu.
Changes
-------
Rebased based on BenH's patches.
Summary (updated)
-----------------
Refactored net::IP and added net::IPv4 and net::IPv6.
Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488
Repository: mesos
Description (updated)
-------
Classes can now initialize the specialized classes whenever they need to
create explicit v4 and v6 addresses, rather than relying on the
`create/Try` semantics of net::IP.
Diffs (updated)
-----
3rdparty/stout/include/stout/ip.hpp ad2bd922158eecd12b51b272d2a003b8ec8d3550
3rdparty/stout/tests/ip_tests.cpp 4c6f81bd53413360182b447ddb149a18e406870e
Diff: https://reviews.apache.org/r/59721/diff/3/
Changes: https://reviews.apache.org/r/59721/diff/2-3/
Testing
-------
make check.
Thanks,
Avinash sridharan
Re: Review Request 59721: Refactored net::IP and added net::IPv4 and
net::IPv6.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59721/#review179684
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On June 29, 2017, 11:24 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59721/
> -----------------------------------------------------------
>
> (Updated June 29, 2017, 11:24 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Bugs: MESOS-7488
> https://issues.apache.org/jira/browse/MESOS-7488
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Classes can now initialize the specialized classes whenever they need to
> create explicit v4 and v6 addresses, rather than relying on the
> `create/Try` semantics of net::IP.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/ip.hpp ee48befac8b9bb4956aec0c5bdebd69347bd5890
> 3rdparty/stout/tests/ip_tests.cpp 39ee0598e3580510a30894fd3f47d2014f596ef7
>
>
> Diff: https://reviews.apache.org/r/59721/diff/5/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 59721: Refactored net::IP and added net::IPv4 and
net::IPv6.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59721/
-----------------------------------------------------------
(Updated June 29, 2017, 11:24 p.m.)
Review request for mesos, Benjamin Hindman and Jie Yu.
Changes
-------
Rebased.
Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488
Repository: mesos
Description
-------
Classes can now initialize the specialized classes whenever they need to
create explicit v4 and v6 addresses, rather than relying on the
`create/Try` semantics of net::IP.
Diffs (updated)
-----
3rdparty/stout/include/stout/ip.hpp ee48befac8b9bb4956aec0c5bdebd69347bd5890
3rdparty/stout/tests/ip_tests.cpp 39ee0598e3580510a30894fd3f47d2014f596ef7
Diff: https://reviews.apache.org/r/59721/diff/5/
Changes: https://reviews.apache.org/r/59721/diff/4-5/
Testing
-------
make check.
Thanks,
Avinash sridharan
Re: Review Request 59721: Refactored net::IP and added net::IPv4 and
net::IPv6.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59721/
-----------------------------------------------------------
(Updated June 16, 2017, 4:46 p.m.)
Review request for mesos, Benjamin Hindman and Jie Yu.
Changes
-------
Rebased.
Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488
Repository: mesos
Description
-------
Classes can now initialize the specialized classes whenever they need to
create explicit v4 and v6 addresses, rather than relying on the
`create/Try` semantics of net::IP.
Diffs (updated)
-----
3rdparty/stout/include/stout/ip.hpp ee48befac8b9bb4956aec0c5bdebd69347bd5890
3rdparty/stout/tests/ip_tests.cpp 39ee0598e3580510a30894fd3f47d2014f596ef7
Diff: https://reviews.apache.org/r/59721/diff/4/
Changes: https://reviews.apache.org/r/59721/diff/3-4/
Testing
-------
make check.
Thanks,
Avinash sridharan