You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/14 09:53:52 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #27576: [SPARK-28869][DOCS][FOLLOWUP] Add direct relationship between configs for rolling event log

HyukjinKwon commented on a change in pull request #27576: [SPARK-28869][DOCS][FOLLOWUP] Add direct relationship between configs for rolling event log
URL: https://github.com/apache/spark/pull/27576#discussion_r379339872
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
 ##########
 @@ -198,7 +198,8 @@ package object config {
 
   private[spark] val EVENT_LOG_ROLLING_MAX_FILE_SIZE =
     ConfigBuilder("spark.eventLog.rolling.maxFileSize")
-      .doc("The max size of event log file to be rolled over.")
+      .doc(s"Precondition: ${EVENT_LOG_ENABLE_ROLLING.key}. " +
 
 Review comment:
   Okay, I saw the new PR https://github.com/apache/spark/pull/27575. We could match how we describe there. Shall we also fix `docs/configuration.md`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org