[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2371: Introduce new `DataFusionError::SchemaError` type

[GitBox <gi...@apache.org>]

alamb commented on code in PR #2371:
URL: https://github.com/apache/arrow-datafusion/pull/2371#discussion_r861226368


##########
datafusion/common/src/error.rs:
##########
@@ -62,8 +62,11 @@ pub enum DataFusionError {
     // This error is raised when one of those invariants is not verified during execution.
     Internal(String),
     /// This error happens whenever a plan is not valid. Examples include
-    /// impossible casts, schema inference not possible and non-unique column names.
+    /// impossible casts.
     Plan(String),
+    /// This error happens with schema-related errors, such as schema inference not possible

Review Comment:
   👍 



##########
datafusion/common/src/error.rs:
##########
@@ -78,6 +81,70 @@ pub enum DataFusionError {
     JITError(ModuleError),
 }
 
+/// Schema-related errors
+#[derive(Debug)]
+pub enum SchemaError {
+    /// Schema contains qualified and unqualified field with same unqualified name

Review Comment:
   ```suggestion
       /// Schema contains a (possibly) qualified and unqualified field with same unqualified name
   ```



##########
datafusion/core/src/sql/planner.rs:
##########
@@ -3740,7 +3740,7 @@ mod tests {
         let err = logical_plan(sql).expect_err("query should have failed");
         assert_eq!(
             "Plan(\"Column Int64(1) (type: Int64) is \
-            not compatible wiht column IntervalMonthDayNano\
+            not compatible with column IntervalMonthDayNano\

Review Comment:
   ❤️ 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org