You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/02/08 18:29:03 UTC
[GitHub] [ozone] adoroszlai commented on a change in pull request #2968: HDDS-6158. list status and list keys output batch size should be configurable.
adoroszlai commented on a change in pull request #2968:
URL: https://github.com/apache/ozone/pull/2968#discussion_r801938081
##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileSystem.java
##########
@@ -99,6 +99,7 @@
public class TestOzoneFileSystem {
private static final float TRASH_INTERVAL = 0.05f; // 3 seconds
+ private static final int listStatusBatchSize = 1024;
Review comment:
I think we can omit this constant and rely on the default. (It's also causing checkstyle failure.)
##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestRootedOzoneFileSystem.java
##########
@@ -109,6 +109,7 @@
LoggerFactory.getLogger(TestRootedOzoneFileSystem.class);
private static final float TRASH_INTERVAL = 0.05f; // 3 seconds
+ private static final int listStatusBatchSize = 1024;
Review comment:
Same here.
##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigKeys.java
##########
@@ -364,6 +364,10 @@
"ozone.fs.iterate.batch-size";
public static final int OZONE_FS_ITERATE_BATCH_SIZE_DEFAULT = 100;
+ public static final String OZONE_FS_LIST_STATUS_BATCH_SIZE =
+ "ozone.fs.list.status.batch-size";
Review comment:
Don't we need a corresponding entry in `ozone-default.xml`?
##########
File path: hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/Constants.java
##########
@@ -33,9 +33,6 @@
/** Temporary directory. */
public static final String BUFFER_TMP_KEY = "hadoop.tmp.dir";
- /** Page size for Ozone listing operation. */
- public static final int LISTING_PAGE_SIZE = 1024;
Review comment:
Since this is public constant in a public class, I think we should deprecate rather than remove it. Not sure why anyone would use it downstream, but it's better to retain compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org