[GitHub] [shardingsphere] yx9o commented on a change in pull request #12144: Fix `SHOW RESOURCES` DistSQL, add `customPoolProps` in result, and add unit test.

[GitBox <gi...@apache.org>]

yx9o commented on a change in pull request #12144:
URL: https://github.com/apache/shardingsphere/pull/12144#discussion_r699976465



##########
File path: shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/distsql/rql/DataSourceQueryResultSet.java
##########
@@ -81,6 +81,7 @@ public boolean next() {
         result.put("maxPoolSize", dataSourceParameter.getMaxPoolSize());
         result.put("minPoolSize", dataSourceParameter.getMinPoolSize());
         result.put("readOnly", dataSourceParameter.isReadOnly());
+        result.put("customPoolProps", dataSourceParameter.getCustomPoolProps());

Review comment:
       > The result of dataSourceParameter.getCustomPoolProps() may be NULL or EMPTY, so a check is needed.
   
   Has been updated, please review, thank you.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org