You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by John Sirois <js...@apache.org> on 2016/02/12 19:31:14 UTC

Review Request 43534: Explain observer `--mesos-root` configuration.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43534/
-----------------------------------------------------------

Review request for Aurora and Stephan Erb.


Bugs: AURORA-1617
    https://issues.apache.org/jira/browse/AURORA-1617


Repository: aurora


Description
-------

This adds a note about configuration of the observer's `--mesos-root` to
match the Mesos master `--work_dir` for proper observer functioning.

 docs/installing.md | 33 ++++++++++++++++++++++++++++++++-
 1 file changed, 32 insertions(+), 1 deletion(-)


Diffs
-----

  docs/installing.md 1620a6fc3ebe428e0269f7edd0377d53ded2c796 

Diff: https://reviews.apache.org/r/43534/diff/


Testing
-------

Rendered here: https://github.com/jsirois/aurora/blob/a335e0ee099c08e52da1a530a2ce2c153a268b1f/docs/installing.md#configuration-1


Thanks,

John Sirois

Re: Review Request 43534: Explain observer `--mesos-root` configuration.

Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43534/#review119058
-----------------------------------------------------------



@ReviewBot retry

- John Sirois


On Feb. 12, 2016, 11:31 a.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43534/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2016, 11:31 a.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Bugs: AURORA-1617
>     https://issues.apache.org/jira/browse/AURORA-1617
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This adds a note about configuration of the observer's `--mesos-root` to
> match the Mesos master `--work_dir` for proper observer functioning.
> 
>  docs/installing.md | 33 ++++++++++++++++++++++++++++++++-
>  1 file changed, 32 insertions(+), 1 deletion(-)
> 
> 
> Diffs
> -----
> 
>   docs/installing.md 1620a6fc3ebe428e0269f7edd0377d53ded2c796 
> 
> Diff: https://reviews.apache.org/r/43534/diff/
> 
> 
> Testing
> -------
> 
> Rendered here: https://github.com/jsirois/aurora/blob/a335e0ee099c08e52da1a530a2ce2c153a268b1f/docs/installing.md#configuration-1
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 43534: Explain observer `--mesos-root` configuration.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43534/#review119057
-----------------------------------------------------------



Master (7d57cf4) is red with this patch.
  ./build-support/jenkins/build.sh

+ date
Fri Feb 12 18:32:58 UTC 2016
+ ./gradlew -Pq clean build
:buildSrc:clean UP-TO-DATE
:buildSrc:compileJava UP-TO-DATE
:buildSrc:compileGroovy
:buildSrc:processResources UP-TO-DATE
:buildSrc:classes
:buildSrc:jar
:buildSrc:assemble
:buildSrc:compileTestJava UP-TO-DATE
:buildSrc:compileTestGroovy UP-TO-DATE
:buildSrc:processTestResources UP-TO-DATE
:buildSrc:testClasses UP-TO-DATE
:buildSrc:test UP-TO-DATE
:buildSrc:check UP-TO-DATE
:buildSrc:build

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring root project 'aurora'.
> Could not open cp_proj class cache for build file '/home/jenkins/jenkins-slave/workspace/AuroraBot/build.gradle' (/home/jenkins/.gradle/caches/2.10/scripts/build_e62v1tfg3vtzz7pxxy2kzgwpr/cp_proj).
   > Timeout waiting to lock cp_proj class cache for build file '/home/jenkins/jenkins-slave/workspace/AuroraBot/build.gradle' (/home/jenkins/.gradle/caches/2.10/scripts/build_e62v1tfg3vtzz7pxxy2kzgwpr/cp_proj). It is currently in use by another Gradle instance.
     Owner PID: unknown
     Our PID: 4362
     Owner Operation: unknown
     Our operation: Initialize cache
     Lock file: /home/jenkins/.gradle/caches/2.10/scripts/build_e62v1tfg3vtzz7pxxy2kzgwpr/cp_proj/cache.properties.lock

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 1 mins 18.483 secs


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Feb. 12, 2016, 6:31 p.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43534/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2016, 6:31 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Bugs: AURORA-1617
>     https://issues.apache.org/jira/browse/AURORA-1617
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This adds a note about configuration of the observer's `--mesos-root` to
> match the Mesos master `--work_dir` for proper observer functioning.
> 
>  docs/installing.md | 33 ++++++++++++++++++++++++++++++++-
>  1 file changed, 32 insertions(+), 1 deletion(-)
> 
> 
> Diffs
> -----
> 
>   docs/installing.md 1620a6fc3ebe428e0269f7edd0377d53ded2c796 
> 
> Diff: https://reviews.apache.org/r/43534/diff/
> 
> 
> Testing
> -------
> 
> Rendered here: https://github.com/jsirois/aurora/blob/a335e0ee099c08e52da1a530a2ce2c153a268b1f/docs/installing.md#configuration-1
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 43534: Explain observer `--mesos-root` configuration.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43534/#review119067
-----------------------------------------------------------


Ship it!




Master (7d57cf4) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Feb. 12, 2016, 6:44 p.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43534/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2016, 6:44 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Bugs: AURORA-1617
>     https://issues.apache.org/jira/browse/AURORA-1617
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This adds a note about configuration of the observer's `--mesos-root` to
> match the Mesos master `--work_dir` for proper observer functioning.
> 
>  docs/installing.md | 33 ++++++++++++++++++++++++++++++++-
>  1 file changed, 32 insertions(+), 1 deletion(-)
> 
> 
> Diffs
> -----
> 
>   docs/installing.md 1620a6fc3ebe428e0269f7edd0377d53ded2c796 
> 
> Diff: https://reviews.apache.org/r/43534/diff/
> 
> 
> Testing
> -------
> 
> Rendered here: https://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1617/docs/installing.md#configuration-1
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 43534: Explain observer `--mesos-root` configuration.

Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43534/
-----------------------------------------------------------

(Updated Feb. 12, 2016, 12:36 p.m.)


Review request for Aurora and Stephan Erb.


Changes
-------

Remove extraneous example output to focus the reader on --mesos-root output.

 docs/installing.md | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)


Bugs: AURORA-1617
    https://issues.apache.org/jira/browse/AURORA-1617


Repository: aurora


Description
-------

This adds a note about configuration of the observer's `--mesos-root` to
match the Mesos master `--work_dir` for proper observer functioning.

 docs/installing.md | 33 ++++++++++++++++++++++++++++++++-
 1 file changed, 32 insertions(+), 1 deletion(-)


Diffs (updated)
-----

  docs/installing.md 1620a6fc3ebe428e0269f7edd0377d53ded2c796 

Diff: https://reviews.apache.org/r/43534/diff/


Testing
-------

Rendered here: https://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1617/docs/installing.md#configuration-1


Thanks,

John Sirois

Re: Review Request 43534: Explain observer `--mesos-root` configuration.

Posted by John Sirois <js...@apache.org>.

> On Feb. 12, 2016, 12:11 p.m., Stephan Erb wrote:
> > docs/installing.md, line 239
> > <https://reviews.apache.org/r/43534/diff/3/?file=1240884#file1240884line239>
> >
> >     I fear that the listed options here might easily become outdated without us noticing.
> 
> John Sirois wrote:
>     Can you suggest a replacement for this output then?
>     My focus is only on the `--mesos-root` `[default...` output, but I have no facility to bold those lines.

I think a simple eliding of the extraneous output here is an improvement, see what you think.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43534/#review119063
-----------------------------------------------------------


On Feb. 12, 2016, 11:44 a.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43534/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2016, 11:44 a.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Bugs: AURORA-1617
>     https://issues.apache.org/jira/browse/AURORA-1617
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This adds a note about configuration of the observer's `--mesos-root` to
> match the Mesos master `--work_dir` for proper observer functioning.
> 
>  docs/installing.md | 33 ++++++++++++++++++++++++++++++++-
>  1 file changed, 32 insertions(+), 1 deletion(-)
> 
> 
> Diffs
> -----
> 
>   docs/installing.md 1620a6fc3ebe428e0269f7edd0377d53ded2c796 
> 
> Diff: https://reviews.apache.org/r/43534/diff/
> 
> 
> Testing
> -------
> 
> Rendered here: https://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1617/docs/installing.md#configuration-1
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 43534: Explain observer `--mesos-root` configuration.

Posted by John Sirois <js...@apache.org>.

> On Feb. 12, 2016, 12:11 p.m., Stephan Erb wrote:
> > docs/installing.md, line 239
> > <https://reviews.apache.org/r/43534/diff/3/?file=1240884#file1240884line239>
> >
> >     I fear that the listed options here might easily become outdated without us noticing.

Can you suggest a replacement for this output then?
My focus is only on the `--mesos-root` `[default...` output, but I have no facility to bold those lines.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43534/#review119063
-----------------------------------------------------------


On Feb. 12, 2016, 11:44 a.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43534/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2016, 11:44 a.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Bugs: AURORA-1617
>     https://issues.apache.org/jira/browse/AURORA-1617
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This adds a note about configuration of the observer's `--mesos-root` to
> match the Mesos master `--work_dir` for proper observer functioning.
> 
>  docs/installing.md | 33 ++++++++++++++++++++++++++++++++-
>  1 file changed, 32 insertions(+), 1 deletion(-)
> 
> 
> Diffs
> -----
> 
>   docs/installing.md 1620a6fc3ebe428e0269f7edd0377d53ded2c796 
> 
> Diff: https://reviews.apache.org/r/43534/diff/
> 
> 
> Testing
> -------
> 
> Rendered here: https://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1617/docs/installing.md#configuration-1
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 43534: Explain observer `--mesos-root` configuration.

Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43534/#review119063
-----------------------------------------------------------


Ship it!





docs/installing.md (line 239)
<https://reviews.apache.org/r/43534/#comment180345>

    I fear that the listed options here might easily become outdated without us noticing.


- Stephan Erb


On Feb. 12, 2016, 7:44 p.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43534/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2016, 7:44 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Bugs: AURORA-1617
>     https://issues.apache.org/jira/browse/AURORA-1617
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This adds a note about configuration of the observer's `--mesos-root` to
> match the Mesos master `--work_dir` for proper observer functioning.
> 
>  docs/installing.md | 33 ++++++++++++++++++++++++++++++++-
>  1 file changed, 32 insertions(+), 1 deletion(-)
> 
> 
> Diffs
> -----
> 
>   docs/installing.md 1620a6fc3ebe428e0269f7edd0377d53ded2c796 
> 
> Diff: https://reviews.apache.org/r/43534/diff/
> 
> 
> Testing
> -------
> 
> Rendered here: https://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1617/docs/installing.md#configuration-1
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 43534: Explain observer `--mesos-root` configuration.

Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43534/#review119062
-----------------------------------------------------------



@ReviewBot retry

- John Sirois


On Feb. 12, 2016, 11:44 a.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43534/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2016, 11:44 a.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Bugs: AURORA-1617
>     https://issues.apache.org/jira/browse/AURORA-1617
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This adds a note about configuration of the observer's `--mesos-root` to
> match the Mesos master `--work_dir` for proper observer functioning.
> 
>  docs/installing.md | 33 ++++++++++++++++++++++++++++++++-
>  1 file changed, 32 insertions(+), 1 deletion(-)
> 
> 
> Diffs
> -----
> 
>   docs/installing.md 1620a6fc3ebe428e0269f7edd0377d53ded2c796 
> 
> Diff: https://reviews.apache.org/r/43534/diff/
> 
> 
> Testing
> -------
> 
> Rendered here: https://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1617/docs/installing.md#configuration-1
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 43534: Explain observer `--mesos-root` configuration.

Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43534/
-----------------------------------------------------------

(Updated Feb. 12, 2016, 11:44 a.m.)


Review request for Aurora and Stephan Erb.


Changes
-------

Fix typo.

 docs/installing.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Bugs: AURORA-1617
    https://issues.apache.org/jira/browse/AURORA-1617


Repository: aurora


Description
-------

This adds a note about configuration of the observer's `--mesos-root` to
match the Mesos master `--work_dir` for proper observer functioning.

 docs/installing.md | 33 ++++++++++++++++++++++++++++++++-
 1 file changed, 32 insertions(+), 1 deletion(-)


Diffs (updated)
-----

  docs/installing.md 1620a6fc3ebe428e0269f7edd0377d53ded2c796 

Diff: https://reviews.apache.org/r/43534/diff/


Testing
-------

Rendered here: https://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1617/docs/installing.md#configuration-1


Thanks,

John Sirois

Re: Review Request 43534: Explain observer `--mesos-root` configuration.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43534/#review119061
-----------------------------------------------------------



Master (7d57cf4) is red with this patch.
  ./build-support/jenkins/build.sh

+ date
Fri Feb 12 18:41:47 UTC 2016
+ ./gradlew -Pq clean build
:buildSrc:clean UP-TO-DATE
:buildSrc:compileJava UP-TO-DATE
:buildSrc:compileGroovy
:buildSrc:processResources UP-TO-DATE
:buildSrc:classes
:buildSrc:jar
:buildSrc:assemble
:buildSrc:compileTestJava UP-TO-DATE
:buildSrc:compileTestGroovy UP-TO-DATE
:buildSrc:processTestResources UP-TO-DATE
:buildSrc:testClasses UP-TO-DATE
:buildSrc:test UP-TO-DATE
:buildSrc:check UP-TO-DATE
:buildSrc:build

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring root project 'aurora'.
> Could not open cp_proj class cache for build file '/home/jenkins/jenkins-slave/workspace/AuroraBot/build.gradle' (/home/jenkins/.gradle/caches/2.10/scripts/build_e62v1tfg3vtzz7pxxy2kzgwpr/cp_proj).
   > Timeout waiting to lock cp_proj class cache for build file '/home/jenkins/jenkins-slave/workspace/AuroraBot/build.gradle' (/home/jenkins/.gradle/caches/2.10/scripts/build_e62v1tfg3vtzz7pxxy2kzgwpr/cp_proj). It is currently in use by another Gradle instance.
     Owner PID: unknown
     Our PID: 10578
     Owner Operation: unknown
     Our operation: Initialize cache
     Lock file: /home/jenkins/.gradle/caches/2.10/scripts/build_e62v1tfg3vtzz7pxxy2kzgwpr/cp_proj/cache.properties.lock

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 1 mins 15.121 secs


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Feb. 12, 2016, 6:40 p.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43534/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2016, 6:40 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Bugs: AURORA-1617
>     https://issues.apache.org/jira/browse/AURORA-1617
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This adds a note about configuration of the observer's `--mesos-root` to
> match the Mesos master `--work_dir` for proper observer functioning.
> 
>  docs/installing.md | 33 ++++++++++++++++++++++++++++++++-
>  1 file changed, 32 insertions(+), 1 deletion(-)
> 
> 
> Diffs
> -----
> 
>   docs/installing.md 1620a6fc3ebe428e0269f7edd0377d53ded2c796 
> 
> Diff: https://reviews.apache.org/r/43534/diff/
> 
> 
> Testing
> -------
> 
> Rendered here: https://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1617/docs/installing.md#configuration-1
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 43534: Explain observer `--mesos-root` configuration.

Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43534/
-----------------------------------------------------------

(Updated Feb. 12, 2016, 11:40 a.m.)


Review request for Aurora and Stephan Erb.


Changes
-------

Fix trailing ws.

 docs/installing.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Bugs: AURORA-1617
    https://issues.apache.org/jira/browse/AURORA-1617


Repository: aurora


Description
-------

This adds a note about configuration of the observer's `--mesos-root` to
match the Mesos master `--work_dir` for proper observer functioning.

 docs/installing.md | 33 ++++++++++++++++++++++++++++++++-
 1 file changed, 32 insertions(+), 1 deletion(-)


Diffs (updated)
-----

  docs/installing.md 1620a6fc3ebe428e0269f7edd0377d53ded2c796 

Diff: https://reviews.apache.org/r/43534/diff/


Testing (updated)
-------

Rendered here: https://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1617/docs/installing.md#configuration-1


Thanks,

John Sirois