You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by jd...@apache.org on 2006/06/01 18:17:00 UTC
svn commit: r410880 -
/geronimo/sandbox/gshell/trunk/gshell-core/src/main/java/org/apache/geronimo/gshell/GShell.java
Author: jdillon
Date: Thu Jun 1 09:17:00 2006
New Revision: 410880
URL: http://svn.apache.org/viewvc?rev=410880&view=rev
Log:
Command line builder as it should be
Modified:
geronimo/sandbox/gshell/trunk/gshell-core/src/main/java/org/apache/geronimo/gshell/GShell.java
Modified: geronimo/sandbox/gshell/trunk/gshell-core/src/main/java/org/apache/geronimo/gshell/GShell.java
URL: http://svn.apache.org/viewvc/geronimo/sandbox/gshell/trunk/gshell-core/src/main/java/org/apache/geronimo/gshell/GShell.java?rev=410880&r1=410879&r2=410880&view=diff
==============================================================================
--- geronimo/sandbox/gshell/trunk/gshell-core/src/main/java/org/apache/geronimo/gshell/GShell.java (original)
+++ geronimo/sandbox/gshell/trunk/gshell-core/src/main/java/org/apache/geronimo/gshell/GShell.java Thu Jun 1 09:17:00 2006
@@ -45,6 +45,8 @@
private final CommandManager commandManager;
+ private final CommandLineBuilder commandLineBuilder;
+
private final Variables vars = new VariablesMap();
public GShell(final IO io) throws CommandException {
@@ -55,10 +57,11 @@
this.io = io;
//
- // HACK: DI CommandManager... Maybe need to setup the top-level container here
+ // HACK: DI components... Maybe need to setup the top-level container here
//
this.commandManager = new CommandManager();
+ this.commandLineBuilder = new CommandLineBuilder(this);
}
public GShell() throws CommandException {
@@ -78,21 +81,11 @@
log.info("Executing (String): " + commandLine);
- //
- // HACK: Just to get something to work...
- //
-
- //
- // TODO: Move builder to field
- //
-
- CommandLineBuilder builder = new CommandLineBuilder(this);
- CommandLine cl = builder.create(commandLine);
+ CommandLine cl = commandLineBuilder.create(commandLine);
cl.execute();
//
- // HACK: Current API needs to be revised to pass data back,
- // will be fixed latger, ignore for now
+ // TODO: Fix API to allow CL to pass back data
//
return 0;