You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Abacn (via GitHub)" <gi...@apache.org> on 2023/02/13 21:53:13 UTC

[GitHub] [beam] Abacn commented on a diff in pull request #25420: [24464] Finalize FileWriteSchemaTransformProvider

Abacn commented on code in PR #25420:
URL: https://github.com/apache/beam/pull/25420#discussion_r1105054235


##########
sdks/java/io/csv/build.gradle:
##########
@@ -31,4 +31,5 @@ dependencies {
     testImplementation project(path: ":sdks:java:core", configuration: "shadowTest")
     testImplementation library.java.junit
     testRuntimeOnly project(path: ":runners:direct-java", configuration: "shadow")
+    testImplementation project(path: ":sdks:java:io:common", configuration: "testRuntimeMigration")

Review Comment:
   Notice this "testRuntimeMigration" is actually a workaround migrating to Gradle 7 (#16307) but somehow the TODO gets removed in #16430. 
   
   CC: @lukecwik Is this configuration still a pending cleanup and are new projects able to get rid of this flag? For this PR we can leave it as is for now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org