[jira] [Commented] (RATIS-141) In RaftClientProtocolService, the assumption of consecutive callId is invalid

["Tsz Wo Nicholas Sze (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RATIS-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248261#comment-16248261 ] 

Tsz Wo Nicholas Sze commented on RATIS-141:
-------------------------------------------

It seems that we need a new id, namely streamId, for the calls in a stream.

> In RaftClientProtocolService, the assumption of consecutive callId is invalid
> -----------------------------------------------------------------------------
>
>                 Key: RATIS-141
>                 URL: https://issues.apache.org/jira/browse/RATIS-141
>             Project: Ratis
>          Issue Type: Bug
>            Reporter: Tsz Wo Nicholas Sze
>
> {code}
> //RaftClientProtocolService.AppendRequestStreamObserver.onNext(..)
>               // we assume the callId is consecutive for a stream RPC call
>               final PendingAppend pendingForReply = pendingList.get(
>                   (int) (replySeq - headSeqNum));
> {code}
> Call id is used for different kinds of calls (e.g. getInfo) so that it may not be consecutive.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)