You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by gi...@git.apache.org on 2017/10/10 18:11:18 UTC

[GitHub] davisp commented on a change in pull request #866: Fix incorrect index selection when sort specified

davisp commented on a change in pull request #866: Fix incorrect index selection when sort specified
URL: https://github.com/apache/couchdb/pull/866#discussion_r143807374
 
 

 ##########
 File path: src/mango/src/mango_idx.erl
 ##########
 @@ -93,17 +109,31 @@ recover(Db) ->
     end, DDocs)}.
 
 
-for_sort(Indexes, Opts) ->
-    % If a sort was specified we have to find an index that
-    % can satisfy the request.
+has_use_index(Opts) ->
+    case lists:keyfind(sort, 1, Opts) of
+        {use_index, _} ->
 
 Review comment:
   This check will never return true as sort is not equal to use_index.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services