[commons-dbutils] 01/02: DBUTILS-149 Add exceptions for EI_EXPOSE_REP and EI_EXPOSE_REP2 to maintain binary compatibility.

[th...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

thecarlhall pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-dbutils.git

commit 150a1b49c7103fcb2baef17a6fab1bba09373db1
Author: Carl Hall <th...@apache.org>
AuthorDate: Sat Jan 14 14:51:29 2023 -0500

    DBUTILS-149 Add exceptions for EI_EXPOSE_REP and EI_EXPOSE_REP2 to maintain binary compatibility.
---
 pom.xml                                     | 5 -----
 src/site/resources/spotbugs/sb-excludes.xml | 7 +++++++
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/pom.xml b/pom.xml
index eab41e7..446e49b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -241,11 +241,6 @@
     <maven.compiler.source>1.7</maven.compiler.source>
     <maven.compiler.target>1.7</maven.compiler.target>
 
-    <!-- Pin Spotbugs to these versions. Upgrading breaks the build due to new analysis rules. -->
-    <!-- See https://issues.apache.org/jira/browse/DBUTILS-149 -->
-    <commons.spotbugs.plugin.version>4.4.2</commons.spotbugs.plugin.version>
-    <commons.spotbugs.impl.version>4.2.3</commons.spotbugs.impl.version>
-
     <dbutils.checkstyle.version>9.3</dbutils.checkstyle.version>
     <checkstyle.header.file>${basedir}/src/site/resources/checkstyle/checkstyle-header.txt</checkstyle.header.file>
     <checkstyle.config.file>${basedir}/src/site/resources/checkstyle/checkstyle.xml</checkstyle.config.file>
diff --git a/src/site/resources/spotbugs/sb-excludes.xml b/src/site/resources/spotbugs/sb-excludes.xml
index d4cdcd4..b9f199c 100644
--- a/src/site/resources/spotbugs/sb-excludes.xml
+++ b/src/site/resources/spotbugs/sb-excludes.xml
@@ -20,6 +20,13 @@
     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
     xsi:schemaLocation="https://github.com/spotbugs/filter/3.0.0 https://raw.githubusercontent.com/spotbugs/spotbugs/3.1.0/spotbugs/etc/findbugsfilter.xsd">
 
+    <!-- TODO Can any of these be done without breaking binary compatibility? -->
+    <Match>
+        <Or>
+            <Bug pattern="EI_EXPOSE_REP" />
+            <Bug pattern="EI_EXPOSE_REP2" />
+        </Or>
+    </Match>
     <!-- PrintWriter wraps System.err which always uses the default encoding -->
     <Match>
         <Class name="org.apache.commons.dbutils.DbUtils" />