You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/12/26 20:25:36 UTC
[GitHub] [iceberg] Fokko opened a new pull request, #6495: Python-legacy: Fix CI
Fokko opened a new pull request, #6495:
URL: https://github.com/apache/iceberg/pull/6495
It looks like the latest version of `tox` clashes with `tox-travis`.
The tox version wasn't pinned in `tox-travis`, and it would just follow the latest version that's available.
This has been fixed in the repository:
https://github.com/tox-dev/tox-travis/commit/e11bacf107903375b5c42bda799e94f5dbe12978
I think it is good to add this constraint in our `setup.py` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #6495: Python-legacy: Fix CI
Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #6495:
URL: https://github.com/apache/iceberg/pull/6495#issuecomment-1368051275
Looks good to me. Thanks for fixing it.
When do you think it will be time to remove the legacy code? I think we're about to the point where we can do everything the legacy code can.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #6495: Python-legacy: Fix CI
Posted by GitBox <gi...@apache.org>.
rdblue merged PR #6495:
URL: https://github.com/apache/iceberg/pull/6495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on pull request #6495: Python-legacy: Fix CI
Posted by GitBox <gi...@apache.org>.
Fokko commented on PR #6495:
URL: https://github.com/apache/iceberg/pull/6495#issuecomment-1368078960
Thanks for merging it. It feels to me that it isn't up to me to remove the old code. Now and then I still look at the old code to get some inspiration, but I agree that most of the functionality is also in PyIceberg by now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org