You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@orc.apache.org by GitBox <gi...@apache.org> on 2023/01/09 17:27:56 UTC

[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1368: ORC-1352: [C++] get rid of ORC_NOEXCEPT/ORC_NULLPTR/ORC_OVERRIDE/ORC_…

dongjoon-hyun commented on code in PR #1368:
URL: https://github.com/apache/orc/pull/1368#discussion_r1064893930


##########
c++/include/orc/orc-config.hh.in:
##########
@@ -25,6 +25,7 @@
   #include <stdint.h>
 #endif
 
+// Following MACROS should be keeped for backward compatibility.

Review Comment:
   Just a question. Do we have any deprecation process in Apache ORC C++, @wgtmac , @stiga-huang ?
   I'm wondering when we can clean up these unused macros in the future.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org