You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "yaooqinn (via GitHub)" <gi...@apache.org> on 2026/02/06 06:32:08 UTC
[PR] [SPARK-55387][CORE][UI] Fix DAG visualization not rendering due to malformed DOT label [spark]
yaooqinn opened a new pull request, #54171:
URL: https://github.com/apache/spark/pull/54171
### What changes were proposed in this pull request?
This PR fixes a typo in `RDDOperationGraph.scala` where an extra `}` character was accidentally added to the DOT node label string, causing the DAG visualization to fail rendering in both Jobs and Stages pages of the Spark Web UI.
**Before (broken):**
```scala
s"""${node.id} [id="node_${node.id}" labelType="html" label="$label}"]"""
```
**After (fixed):**
```scala
s"""${node.id} [id="node_${node.id}" labelType="html" label="$label"]"""
```
### Why are the changes needed?
The DAG visualization in the Spark Web UI is completely broken. Instead of rendering the graph, it shows the raw DOT source text. This affects both Jobs and Stages views across all browsers (Firefox, Edge, Chrome) and both Spark Shell and PySpark.
This regression was introduced in SPARK-45274 (PR #43053).
### Does this PR introduce _any_ user-facing change?
Yes. The DAG visualization in the Spark Web UI will render correctly again.
**Before:** Raw DOT graph source displayed instead of visualization
**After:** Properly rendered DAG graph
### How was this patch tested?
- Existing unit tests pass: `RDDOperationGraphSuite`, `UISeleniumSuite` (DAG visualization test)
- Manual verification with `sc.range(0, 10, 1, 4).count()` in spark-shell
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55387][CORE][UI] Fix DAG visualization not rendering due to malformed DOT label [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #54171:
URL: https://github.com/apache/spark/pull/54171#issuecomment-3859229775
> Existing unit tests pass: RDDOperationGraphSuite, UISeleniumSuite (DAG visualization test)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55387][CORE][UI] Fix DAG visualization not rendering due to malformed DOT label [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #54171:
URL: https://github.com/apache/spark/pull/54171#issuecomment-3858700831
@dongjoon-hyun Thank you for the in-depth validation, it looks this issue is resonant with jetty? It's looks like we can also have it landed in 4.0/4.1 as it's just a one-line change.
Thank you @sarutak too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55387][CORE][UI] Fix DAG visualization not rendering due to malformed DOT label [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #54171:
URL: https://github.com/apache/spark/pull/54171#issuecomment-3859074259
thanks for the quick fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55387][CORE][UI] Fix DAG visualization not rendering due to malformed DOT label [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #54171:
URL: https://github.com/apache/spark/pull/54171#issuecomment-3858303816
cc @zhengruifeng @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55387][CORE][UI] Fix DAG visualization not rendering due to malformed DOT label [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #54171:
URL: https://github.com/apache/spark/pull/54171#issuecomment-3860511242
For the backporting, +1 for this one-liner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55387][CORE][UI] Fix DAG visualization not rendering due to malformed DOT label [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #54171:
URL: https://github.com/apache/spark/pull/54171#issuecomment-3858456998
I reproduced it in only at `Apache Spark 4.2.0-preview2` and the error looks like due to new `jetty`.
- https://github.com/apache/spark/pull/53116
```
26/02/05 23:11:18 ERROR ServerRuntime$Responder: Error while closing the output stream in order to commit response.
java.io.UncheckedIOException: org.sparkproject.jetty.io.EofException: Broken pipe
at org.glassfish.jersey.message.internal.OutboundMessageContext.close(OutboundMessageContext.java:571)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55387][CORE][UI] Fix DAG visualization not rendering due to malformed DOT label [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #54171:
URL: https://github.com/apache/spark/pull/54171#issuecomment-3859740965
Add a test for this case is tricky, but the overall DOT validation worth a try
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55387][CORE][UI] Fix DAG visualization not rendering due to malformed DOT label [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #54171:
URL: https://github.com/apache/spark/pull/54171#issuecomment-3858415036
It's strange. For me, 4.1.1 looks okay to me with @zhengruifeng 's example. According to the code, 4.1.1 should be broken, right?
> This regression was introduced in [SPARK-45274](https://issues.apache.org/jira/browse/SPARK-45274) (PR https://github.com/apache/spark/pull/43053).
<img width="392" height="569" alt="Screenshot 2026-02-05 at 22 57 09" src="https://github.com/user-attachments/assets/5b6cfeff-1525-4a6e-8e16-ba01a0de22e8" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55387][CORE][UI] Fix DAG visualization not rendering due to malformed DOT label [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #54171:
URL: https://github.com/apache/spark/pull/54171#issuecomment-3858294129
## JIRA Issue Information
=== Bug SPARK-55387 ===
Summary: Broken DAG Visualization in Spark UI
Assignee: None
Status: Open
Affected: ["4.2.0"]
---
*This comment was automatically generated by GitHub Actions*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55387][CORE][UI] Fix DAG visualization not rendering due to malformed DOT label [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #54171:
URL: https://github.com/apache/spark/pull/54171#issuecomment-3858461325
cc @sarutak and @HyukjinKwon
For the record, the on-going preview2 vote is not blocked by this because it's just a monthly preview. Initially, we decided not to be blocked for monthly previews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55387][CORE][UI] Fix DAG visualization not rendering due to malformed DOT label [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #54171:
URL: https://github.com/apache/spark/pull/54171#issuecomment-3859135061
+1 to backport it to 4.0/4.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55387][CORE][UI] Fix DAG visualization not rendering due to malformed DOT label [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn closed pull request #54171: [SPARK-55387][CORE][UI] Fix DAG visualization not rendering due to malformed DOT label
URL: https://github.com/apache/spark/pull/54171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org