You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2016/01/11 14:13:59 UTC
Re: Review Request 41876: Used std::list as opposed to List from
stout.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41876/
-----------------------------------------------------------
(Updated Jan. 11, 2016, 2:13 p.m.)
Review request for mesos, Ben Mahler and Till Toenshoff.
Changes
-------
Migrated from stout's List to std::list.
Summary (updated)
-----------------
Used std::list as opposed to List from stout.
Bugs: MESOS-4273
https://issues.apache.org/jira/browse/MESOS-4273
Repository: mesos
Description (updated)
-------
List from stout provides no advantage over std::list now that C++11 is
available.
Review: https://reviews.apache.org/r/41876
Diffs (updated)
-----
3rdparty/libprocess/src/tests/subprocess_tests.cpp 8f0a31341eebb168f78bc74f8afbaef9ba98e847
3rdparty/libprocess/src/tests/timeseries_tests.cpp 274598e63d28150aaa0ad06fa2d85e41e525c153
Diff: https://reviews.apache.org/r/41876/diff/
Testing
-------
Thanks,
Benjamin Bannier
Re: Review Request 41876: Used std::list as opposed to List from
stout.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41876/#review114169
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On Jan. 13, 2016, 11:02 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41876/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2016, 11:02 a.m.)
>
>
> Review request for mesos, Ben Mahler and Till Toenshoff.
>
>
> Bugs: MESOS-4273
> https://issues.apache.org/jira/browse/MESOS-4273
>
>
> Repository: mesos
>
>
> Description
> -------
>
> List from stout provides no advantage over std::list now that C++11 is
> available.
>
> Review: https://reviews.apache.org/r/41876
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/subprocess_tests.cpp 8f0a31341eebb168f78bc74f8afbaef9ba98e847
> 3rdparty/libprocess/src/tests/timeseries_tests.cpp 274598e63d28150aaa0ad06fa2d85e41e525c153
>
> Diff: https://reviews.apache.org/r/41876/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 41876: Used std::list as opposed to List from
stout.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41876/
-----------------------------------------------------------
(Updated Jan. 13, 2016, 11:02 a.m.)
Review request for mesos, Ben Mahler and Till Toenshoff.
Changes
-------
Removed old and unused dep (which created a cycle here that made apply-reviews.py hang).
Bugs: MESOS-4273
https://issues.apache.org/jira/browse/MESOS-4273
Repository: mesos
Description
-------
List from stout provides no advantage over std::list now that C++11 is
available.
Review: https://reviews.apache.org/r/41876
Diffs
-----
3rdparty/libprocess/src/tests/subprocess_tests.cpp 8f0a31341eebb168f78bc74f8afbaef9ba98e847
3rdparty/libprocess/src/tests/timeseries_tests.cpp 274598e63d28150aaa0ad06fa2d85e41e525c153
Diff: https://reviews.apache.org/r/41876/diff/
Testing
-------
Thanks,
Benjamin Bannier
Re: Review Request 41876: Used std::list as opposed to List from
stout.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41876/#review113993
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Schlicht
On Jan. 11, 2016, 2:13 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41876/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2016, 2:13 p.m.)
>
>
> Review request for mesos, Ben Mahler and Till Toenshoff.
>
>
> Bugs: MESOS-4273
> https://issues.apache.org/jira/browse/MESOS-4273
>
>
> Repository: mesos
>
>
> Description
> -------
>
> List from stout provides no advantage over std::list now that C++11 is
> available.
>
> Review: https://reviews.apache.org/r/41876
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/subprocess_tests.cpp 8f0a31341eebb168f78bc74f8afbaef9ba98e847
> 3rdparty/libprocess/src/tests/timeseries_tests.cpp 274598e63d28150aaa0ad06fa2d85e41e525c153
>
> Diff: https://reviews.apache.org/r/41876/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Bannier
>
>