You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@calcite.apache.org by Francis Chuang <fr...@apache.org> on 2018/09/04 22:38:23 UTC
Re: [VOTE] Release calcite-avatica-go-3.1.0 (release candidate 1)
Hi All,
Just a reminder that Apache Calcite Avatica Go 3.1.0-rc1 is available
for voting. If you have a chance, please try to run the tests, verify
the signature and vote. Your vote will be extremely useful to determine
if this release candidate is suitable to release.
Francis
On 31/08/2018 10:35 AM, Francis Chuang wrote:
> Hi all,
>
> I have created a release for Apache Calcite Avatica Go 3.1.0, release
> candidate 1.
>
> The release notes are available here:
> https://github.com/apache/calcite-avatica-go/blob/master/site/_docs/go_history.md
>
> The commit to be voted on:
> http://git-wip-us.apache.org/repos/asf/calcite-avatica-go/commit/f564cfa42948b9a5c4c7f98f3e43ab5971bcaeda
>
> The hash is f564cfa42948b9a5c4c7f98f3e43ab5971bcaeda
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-go-3.1.0-rc1/
>
> The hashes of the artifacts are as follows:
>
> src.tar.gz.sha256 64BC4D9D 197457DC B0573F12 4A75A298 CB5207D6 FDC14DCB 675FF731 0555F5A3
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/francischuang.asc
>
> Instructions for running the test suite is located here:
> https://github.com/apache/calcite-avatica-go/blob/master/site/develop/avatica-go.md#testing
>
> Please vote on releasing this package as Apache Calcite Avatica Go 3.1.0.
>
> To run the tests without a Go environment, install docker and docker-compose. Then, in the root of the release's directory, run:
> docker-compose up --build
>
> The vote is open for the next 72 hours and passes if a majority of
> at least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite Avatica Go 3.0.0
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
>
> Here is my vote:
>
> +1 (binding)
>
> Francis
>
Re: [VOTE] Release calcite-avatica-go-3.1.0 (release candidate 1)
Posted by Francis Chuang <fr...@apache.org>.
Great idea! I'll do this instead.
On 5/09/2018 7:36 PM, Julian Hyde wrote:
> You could use
>
> tar ... $(git ls-files)
>
> Easier than using .gitignore I think.
>
>> On Sep 5, 2018, at 2:28 AM, Francis Chuang <fr...@apache.org> wrote:
>>
>> Thanks for voting, Julian.
>>
>> I will update the release script to use the .gitignore file to exclude folders when building the tar.gz.
>>
>> I will also add a check to check if the year == current year when building a release.
>>
>> If you have docker on your machine, you can run "docker-compose up --build" from the root directory to run tests. I recommend having at least 8GB of RAM, as Phoenix is quite heavy.
>>
>> I will cancel this vote and start a new one tomorrow.
>>
>>> On 5/09/2018 6:21 PM, Julian Hyde wrote:
>>> The .tar.gz contains a .idea directory that is not in source-control:
>>>
>>> .idea/
>>> .idea/go.imports.xml
>>> .idea/inspectionProfiles
>>> .idea/workspace.xml
>>> .idea/vcs.xml
>>> .idea/dataSources
>>> .idea/dataSources/8818a189-beb8-4519-a1af-aec6a92afd20.xml
>>> .idea/dataSources/ed276130-2ebd-463d-b1a0-78e39ca4d29f.xml
>>> .idea/calcite-avatica-go.iml
>>> .idea/watcherTasks.xml
>>> .idea/dataSources.local.xml
>>> .idea/usage.statistics.xml
>>> .idea/misc.xml
>>> .idea/dataSources.xml
>>> .idea/modules.xml
>>>
>>> In NOTICE, copyright should be 2012-2018 not 2012-2017.
>>>
>>> Due to these issues, my vote is -1.
>>>
>>> Checked LICENSE, README.md, checksums/signatures, file headers.
>>>
>>> I did not build or run tests, or check that dependencies have suitable
>>> licenses. I don't know enough about Go. Can someone else please do
>>> that.
>>>
>>> Julian
>>>
>>>> On Tue, Sep 4, 2018 at 3:38 PM Francis Chuang <fr...@apache.org> wrote:
>>>> Hi All,
>>>>
>>>> Just a reminder that Apache Calcite Avatica Go 3.1.0-rc1 is available
>>>> for voting. If you have a chance, please try to run the tests, verify
>>>> the signature and vote. Your vote will be extremely useful to determine
>>>> if this release candidate is suitable to release.
>>>>
>>>> Francis
>>>>
>>>>> On 31/08/2018 10:35 AM, Francis Chuang wrote:
>>>>> Hi all,
>>>>>
>>>>> I have created a release for Apache Calcite Avatica Go 3.1.0, release
>>>>> candidate 1.
>>>>>
>>>>> The release notes are available here:
>>>>> https://github.com/apache/calcite-avatica-go/blob/master/site/_docs/go_history.md
>>>>>
>>>>> The commit to be voted on:
>>>>> http://git-wip-us.apache.org/repos/asf/calcite-avatica-go/commit/f564cfa42948b9a5c4c7f98f3e43ab5971bcaeda
>>>>>
>>>>> The hash is f564cfa42948b9a5c4c7f98f3e43ab5971bcaeda
>>>>>
>>>>> The artifacts to be voted on are located here:
>>>>> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-go-3.1.0-rc1/
>>>>>
>>>>> The hashes of the artifacts are as follows:
>>>>>
>>>>> src.tar.gz.sha256 64BC4D9D 197457DC B0573F12 4A75A298 CB5207D6 FDC14DCB 675FF731 0555F5A3
>>>>>
>>>>> Release artifacts are signed with the following key:
>>>>> https://people.apache.org/keys/committer/francischuang.asc
>>>>>
>>>>> Instructions for running the test suite is located here:
>>>>> https://github.com/apache/calcite-avatica-go/blob/master/site/develop/avatica-go.md#testing
>>>>>
>>>>> Please vote on releasing this package as Apache Calcite Avatica Go 3.1.0.
>>>>>
>>>>> To run the tests without a Go environment, install docker and docker-compose. Then, in the root of the release's directory, run:
>>>>> docker-compose up --build
>>>>>
>>>>> The vote is open for the next 72 hours and passes if a majority of
>>>>> at least three +1 PMC votes are cast.
>>>>>
>>>>> [ ] +1 Release this package as Apache Calcite Avatica Go 3.0.0
>>>>> [ ] 0 I don't feel strongly about it, but I'm okay with the release
>>>>> [ ] -1 Do not release this package because...
>>>>>
>>>>>
>>>>> Here is my vote:
>>>>>
>>>>> +1 (binding)
>>>>>
>>>>> Francis
>>>>>
Re: [VOTE] Release calcite-avatica-go-3.1.0 (release candidate 1)
Posted by Julian Hyde <jh...@gmail.com>.
You could use
tar ... $(git ls-files)
Easier than using .gitignore I think.
> On Sep 5, 2018, at 2:28 AM, Francis Chuang <fr...@apache.org> wrote:
>
> Thanks for voting, Julian.
>
> I will update the release script to use the .gitignore file to exclude folders when building the tar.gz.
>
> I will also add a check to check if the year == current year when building a release.
>
> If you have docker on your machine, you can run "docker-compose up --build" from the root directory to run tests. I recommend having at least 8GB of RAM, as Phoenix is quite heavy.
>
> I will cancel this vote and start a new one tomorrow.
>
>> On 5/09/2018 6:21 PM, Julian Hyde wrote:
>> The .tar.gz contains a .idea directory that is not in source-control:
>>
>> .idea/
>> .idea/go.imports.xml
>> .idea/inspectionProfiles
>> .idea/workspace.xml
>> .idea/vcs.xml
>> .idea/dataSources
>> .idea/dataSources/8818a189-beb8-4519-a1af-aec6a92afd20.xml
>> .idea/dataSources/ed276130-2ebd-463d-b1a0-78e39ca4d29f.xml
>> .idea/calcite-avatica-go.iml
>> .idea/watcherTasks.xml
>> .idea/dataSources.local.xml
>> .idea/usage.statistics.xml
>> .idea/misc.xml
>> .idea/dataSources.xml
>> .idea/modules.xml
>>
>> In NOTICE, copyright should be 2012-2018 not 2012-2017.
>>
>> Due to these issues, my vote is -1.
>>
>> Checked LICENSE, README.md, checksums/signatures, file headers.
>>
>> I did not build or run tests, or check that dependencies have suitable
>> licenses. I don't know enough about Go. Can someone else please do
>> that.
>>
>> Julian
>>
>>> On Tue, Sep 4, 2018 at 3:38 PM Francis Chuang <fr...@apache.org> wrote:
>>> Hi All,
>>>
>>> Just a reminder that Apache Calcite Avatica Go 3.1.0-rc1 is available
>>> for voting. If you have a chance, please try to run the tests, verify
>>> the signature and vote. Your vote will be extremely useful to determine
>>> if this release candidate is suitable to release.
>>>
>>> Francis
>>>
>>>> On 31/08/2018 10:35 AM, Francis Chuang wrote:
>>>> Hi all,
>>>>
>>>> I have created a release for Apache Calcite Avatica Go 3.1.0, release
>>>> candidate 1.
>>>>
>>>> The release notes are available here:
>>>> https://github.com/apache/calcite-avatica-go/blob/master/site/_docs/go_history.md
>>>>
>>>> The commit to be voted on:
>>>> http://git-wip-us.apache.org/repos/asf/calcite-avatica-go/commit/f564cfa42948b9a5c4c7f98f3e43ab5971bcaeda
>>>>
>>>> The hash is f564cfa42948b9a5c4c7f98f3e43ab5971bcaeda
>>>>
>>>> The artifacts to be voted on are located here:
>>>> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-go-3.1.0-rc1/
>>>>
>>>> The hashes of the artifacts are as follows:
>>>>
>>>> src.tar.gz.sha256 64BC4D9D 197457DC B0573F12 4A75A298 CB5207D6 FDC14DCB 675FF731 0555F5A3
>>>>
>>>> Release artifacts are signed with the following key:
>>>> https://people.apache.org/keys/committer/francischuang.asc
>>>>
>>>> Instructions for running the test suite is located here:
>>>> https://github.com/apache/calcite-avatica-go/blob/master/site/develop/avatica-go.md#testing
>>>>
>>>> Please vote on releasing this package as Apache Calcite Avatica Go 3.1.0.
>>>>
>>>> To run the tests without a Go environment, install docker and docker-compose. Then, in the root of the release's directory, run:
>>>> docker-compose up --build
>>>>
>>>> The vote is open for the next 72 hours and passes if a majority of
>>>> at least three +1 PMC votes are cast.
>>>>
>>>> [ ] +1 Release this package as Apache Calcite Avatica Go 3.0.0
>>>> [ ] 0 I don't feel strongly about it, but I'm okay with the release
>>>> [ ] -1 Do not release this package because...
>>>>
>>>>
>>>> Here is my vote:
>>>>
>>>> +1 (binding)
>>>>
>>>> Francis
>>>>
>
Re: [VOTE] Release calcite-avatica-go-3.1.0 (release candidate 1)
Posted by Francis Chuang <fr...@apache.org>.
They should point to the same version.
I haven't found the .bat file to be useful, do you guys thinks it should
be removed?
On 5/09/2018 7:33 PM, Sergey Nuyanzin wrote:
> After downloading I found a strange(at least for me) thing:
> gen-protobuf.bat and gen-protobuf.sh point to different avatica version.
> I can not say if it is a blocker or not here but I wonder if on Windows it
> should be the same?
>
> On Wed, Sep 5, 2018 at 12:28 PM Francis Chuang <fr...@apache.org>
> wrote:
>
>> Thanks for voting, Julian.
>>
>> I will update the release script to use the .gitignore file to exclude
>> folders when building the tar.gz.
>>
>> I will also add a check to check if the year == current year when
>> building a release.
>>
>> If you have docker on your machine, you can run "docker-compose up
>> --build" from the root directory to run tests. I recommend having at
>> least 8GB of RAM, as Phoenix is quite heavy.
>>
>> I will cancel this vote and start a new one tomorrow.
>>
>> On 5/09/2018 6:21 PM, Julian Hyde wrote:
>>> The .tar.gz contains a .idea directory that is not in source-control:
>>>
>>> .idea/
>>> .idea/go.imports.xml
>>> .idea/inspectionProfiles
>>> .idea/workspace.xml
>>> .idea/vcs.xml
>>> .idea/dataSources
>>> .idea/dataSources/8818a189-beb8-4519-a1af-aec6a92afd20.xml
>>> .idea/dataSources/ed276130-2ebd-463d-b1a0-78e39ca4d29f.xml
>>> .idea/calcite-avatica-go.iml
>>> .idea/watcherTasks.xml
>>> .idea/dataSources.local.xml
>>> .idea/usage.statistics.xml
>>> .idea/misc.xml
>>> .idea/dataSources.xml
>>> .idea/modules.xml
>>>
>>> In NOTICE, copyright should be 2012-2018 not 2012-2017.
>>>
>>> Due to these issues, my vote is -1.
>>>
>>> Checked LICENSE, README.md, checksums/signatures, file headers.
>>>
>>> I did not build or run tests, or check that dependencies have suitable
>>> licenses. I don't know enough about Go. Can someone else please do
>>> that.
>>>
>>> Julian
>>>
>>> On Tue, Sep 4, 2018 at 3:38 PM Francis Chuang <fr...@apache.org>
>> wrote:
>>>> Hi All,
>>>>
>>>> Just a reminder that Apache Calcite Avatica Go 3.1.0-rc1 is available
>>>> for voting. If you have a chance, please try to run the tests, verify
>>>> the signature and vote. Your vote will be extremely useful to determine
>>>> if this release candidate is suitable to release.
>>>>
>>>> Francis
>>>>
>>>> On 31/08/2018 10:35 AM, Francis Chuang wrote:
>>>>> Hi all,
>>>>>
>>>>> I have created a release for Apache Calcite Avatica Go 3.1.0, release
>>>>> candidate 1.
>>>>>
>>>>> The release notes are available here:
>>>>>
>> https://github.com/apache/calcite-avatica-go/blob/master/site/_docs/go_history.md
>>>>> The commit to be voted on:
>>>>>
>> http://git-wip-us.apache.org/repos/asf/calcite-avatica-go/commit/f564cfa42948b9a5c4c7f98f3e43ab5971bcaeda
>>>>> The hash is f564cfa42948b9a5c4c7f98f3e43ab5971bcaeda
>>>>>
>>>>> The artifacts to be voted on are located here:
>>>>>
>> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-go-3.1.0-rc1/
>>>>> The hashes of the artifacts are as follows:
>>>>>
>>>>> src.tar.gz.sha256 64BC4D9D 197457DC B0573F12 4A75A298 CB5207D6
>> FDC14DCB 675FF731 0555F5A3
>>>>> Release artifacts are signed with the following key:
>>>>> https://people.apache.org/keys/committer/francischuang.asc
>>>>>
>>>>> Instructions for running the test suite is located here:
>>>>>
>> https://github.com/apache/calcite-avatica-go/blob/master/site/develop/avatica-go.md#testing
>>>>> Please vote on releasing this package as Apache Calcite Avatica Go
>> 3.1.0.
>>>>> To run the tests without a Go environment, install docker and
>> docker-compose. Then, in the root of the release's directory, run:
>>>>> docker-compose up --build
>>>>>
>>>>> The vote is open for the next 72 hours and passes if a majority of
>>>>> at least three +1 PMC votes are cast.
>>>>>
>>>>> [ ] +1 Release this package as Apache Calcite Avatica Go 3.0.0
>>>>> [ ] 0 I don't feel strongly about it, but I'm okay with the release
>>>>> [ ] -1 Do not release this package because...
>>>>>
>>>>>
>>>>> Here is my vote:
>>>>>
>>>>> +1 (binding)
>>>>>
>>>>> Francis
>>>>>
>>
Re: [VOTE] Release calcite-avatica-go-3.1.0 (release candidate 1)
Posted by Sergey Nuyanzin <sn...@gmail.com>.
After downloading I found a strange(at least for me) thing:
gen-protobuf.bat and gen-protobuf.sh point to different avatica version.
I can not say if it is a blocker or not here but I wonder if on Windows it
should be the same?
On Wed, Sep 5, 2018 at 12:28 PM Francis Chuang <fr...@apache.org>
wrote:
> Thanks for voting, Julian.
>
> I will update the release script to use the .gitignore file to exclude
> folders when building the tar.gz.
>
> I will also add a check to check if the year == current year when
> building a release.
>
> If you have docker on your machine, you can run "docker-compose up
> --build" from the root directory to run tests. I recommend having at
> least 8GB of RAM, as Phoenix is quite heavy.
>
> I will cancel this vote and start a new one tomorrow.
>
> On 5/09/2018 6:21 PM, Julian Hyde wrote:
> > The .tar.gz contains a .idea directory that is not in source-control:
> >
> > .idea/
> > .idea/go.imports.xml
> > .idea/inspectionProfiles
> > .idea/workspace.xml
> > .idea/vcs.xml
> > .idea/dataSources
> > .idea/dataSources/8818a189-beb8-4519-a1af-aec6a92afd20.xml
> > .idea/dataSources/ed276130-2ebd-463d-b1a0-78e39ca4d29f.xml
> > .idea/calcite-avatica-go.iml
> > .idea/watcherTasks.xml
> > .idea/dataSources.local.xml
> > .idea/usage.statistics.xml
> > .idea/misc.xml
> > .idea/dataSources.xml
> > .idea/modules.xml
> >
> > In NOTICE, copyright should be 2012-2018 not 2012-2017.
> >
> > Due to these issues, my vote is -1.
> >
> > Checked LICENSE, README.md, checksums/signatures, file headers.
> >
> > I did not build or run tests, or check that dependencies have suitable
> > licenses. I don't know enough about Go. Can someone else please do
> > that.
> >
> > Julian
> >
> > On Tue, Sep 4, 2018 at 3:38 PM Francis Chuang <fr...@apache.org>
> wrote:
> >> Hi All,
> >>
> >> Just a reminder that Apache Calcite Avatica Go 3.1.0-rc1 is available
> >> for voting. If you have a chance, please try to run the tests, verify
> >> the signature and vote. Your vote will be extremely useful to determine
> >> if this release candidate is suitable to release.
> >>
> >> Francis
> >>
> >> On 31/08/2018 10:35 AM, Francis Chuang wrote:
> >>> Hi all,
> >>>
> >>> I have created a release for Apache Calcite Avatica Go 3.1.0, release
> >>> candidate 1.
> >>>
> >>> The release notes are available here:
> >>>
> https://github.com/apache/calcite-avatica-go/blob/master/site/_docs/go_history.md
> >>>
> >>> The commit to be voted on:
> >>>
> http://git-wip-us.apache.org/repos/asf/calcite-avatica-go/commit/f564cfa42948b9a5c4c7f98f3e43ab5971bcaeda
> >>>
> >>> The hash is f564cfa42948b9a5c4c7f98f3e43ab5971bcaeda
> >>>
> >>> The artifacts to be voted on are located here:
> >>>
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-go-3.1.0-rc1/
> >>>
> >>> The hashes of the artifacts are as follows:
> >>>
> >>> src.tar.gz.sha256 64BC4D9D 197457DC B0573F12 4A75A298 CB5207D6
> FDC14DCB 675FF731 0555F5A3
> >>>
> >>> Release artifacts are signed with the following key:
> >>> https://people.apache.org/keys/committer/francischuang.asc
> >>>
> >>> Instructions for running the test suite is located here:
> >>>
> https://github.com/apache/calcite-avatica-go/blob/master/site/develop/avatica-go.md#testing
> >>>
> >>> Please vote on releasing this package as Apache Calcite Avatica Go
> 3.1.0.
> >>>
> >>> To run the tests without a Go environment, install docker and
> docker-compose. Then, in the root of the release's directory, run:
> >>> docker-compose up --build
> >>>
> >>> The vote is open for the next 72 hours and passes if a majority of
> >>> at least three +1 PMC votes are cast.
> >>>
> >>> [ ] +1 Release this package as Apache Calcite Avatica Go 3.0.0
> >>> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> >>> [ ] -1 Do not release this package because...
> >>>
> >>>
> >>> Here is my vote:
> >>>
> >>> +1 (binding)
> >>>
> >>> Francis
> >>>
>
>
--
Best regards,
Sergey
Re: [VOTE] Release calcite-avatica-go-3.1.0 (release candidate 1)
Posted by Francis Chuang <fr...@apache.org>.
Thanks for voting, Julian.
I will update the release script to use the .gitignore file to exclude
folders when building the tar.gz.
I will also add a check to check if the year == current year when
building a release.
If you have docker on your machine, you can run "docker-compose up
--build" from the root directory to run tests. I recommend having at
least 8GB of RAM, as Phoenix is quite heavy.
I will cancel this vote and start a new one tomorrow.
On 5/09/2018 6:21 PM, Julian Hyde wrote:
> The .tar.gz contains a .idea directory that is not in source-control:
>
> .idea/
> .idea/go.imports.xml
> .idea/inspectionProfiles
> .idea/workspace.xml
> .idea/vcs.xml
> .idea/dataSources
> .idea/dataSources/8818a189-beb8-4519-a1af-aec6a92afd20.xml
> .idea/dataSources/ed276130-2ebd-463d-b1a0-78e39ca4d29f.xml
> .idea/calcite-avatica-go.iml
> .idea/watcherTasks.xml
> .idea/dataSources.local.xml
> .idea/usage.statistics.xml
> .idea/misc.xml
> .idea/dataSources.xml
> .idea/modules.xml
>
> In NOTICE, copyright should be 2012-2018 not 2012-2017.
>
> Due to these issues, my vote is -1.
>
> Checked LICENSE, README.md, checksums/signatures, file headers.
>
> I did not build or run tests, or check that dependencies have suitable
> licenses. I don't know enough about Go. Can someone else please do
> that.
>
> Julian
>
> On Tue, Sep 4, 2018 at 3:38 PM Francis Chuang <fr...@apache.org> wrote:
>> Hi All,
>>
>> Just a reminder that Apache Calcite Avatica Go 3.1.0-rc1 is available
>> for voting. If you have a chance, please try to run the tests, verify
>> the signature and vote. Your vote will be extremely useful to determine
>> if this release candidate is suitable to release.
>>
>> Francis
>>
>> On 31/08/2018 10:35 AM, Francis Chuang wrote:
>>> Hi all,
>>>
>>> I have created a release for Apache Calcite Avatica Go 3.1.0, release
>>> candidate 1.
>>>
>>> The release notes are available here:
>>> https://github.com/apache/calcite-avatica-go/blob/master/site/_docs/go_history.md
>>>
>>> The commit to be voted on:
>>> http://git-wip-us.apache.org/repos/asf/calcite-avatica-go/commit/f564cfa42948b9a5c4c7f98f3e43ab5971bcaeda
>>>
>>> The hash is f564cfa42948b9a5c4c7f98f3e43ab5971bcaeda
>>>
>>> The artifacts to be voted on are located here:
>>> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-go-3.1.0-rc1/
>>>
>>> The hashes of the artifacts are as follows:
>>>
>>> src.tar.gz.sha256 64BC4D9D 197457DC B0573F12 4A75A298 CB5207D6 FDC14DCB 675FF731 0555F5A3
>>>
>>> Release artifacts are signed with the following key:
>>> https://people.apache.org/keys/committer/francischuang.asc
>>>
>>> Instructions for running the test suite is located here:
>>> https://github.com/apache/calcite-avatica-go/blob/master/site/develop/avatica-go.md#testing
>>>
>>> Please vote on releasing this package as Apache Calcite Avatica Go 3.1.0.
>>>
>>> To run the tests without a Go environment, install docker and docker-compose. Then, in the root of the release's directory, run:
>>> docker-compose up --build
>>>
>>> The vote is open for the next 72 hours and passes if a majority of
>>> at least three +1 PMC votes are cast.
>>>
>>> [ ] +1 Release this package as Apache Calcite Avatica Go 3.0.0
>>> [ ] 0 I don't feel strongly about it, but I'm okay with the release
>>> [ ] -1 Do not release this package because...
>>>
>>>
>>> Here is my vote:
>>>
>>> +1 (binding)
>>>
>>> Francis
>>>
Re: [VOTE] Release calcite-avatica-go-3.1.0 (release candidate 1)
Posted by Julian Hyde <jh...@apache.org>.
The .tar.gz contains a .idea directory that is not in source-control:
.idea/
.idea/go.imports.xml
.idea/inspectionProfiles
.idea/workspace.xml
.idea/vcs.xml
.idea/dataSources
.idea/dataSources/8818a189-beb8-4519-a1af-aec6a92afd20.xml
.idea/dataSources/ed276130-2ebd-463d-b1a0-78e39ca4d29f.xml
.idea/calcite-avatica-go.iml
.idea/watcherTasks.xml
.idea/dataSources.local.xml
.idea/usage.statistics.xml
.idea/misc.xml
.idea/dataSources.xml
.idea/modules.xml
In NOTICE, copyright should be 2012-2018 not 2012-2017.
Due to these issues, my vote is -1.
Checked LICENSE, README.md, checksums/signatures, file headers.
I did not build or run tests, or check that dependencies have suitable
licenses. I don't know enough about Go. Can someone else please do
that.
Julian
On Tue, Sep 4, 2018 at 3:38 PM Francis Chuang <fr...@apache.org> wrote:
>
> Hi All,
>
> Just a reminder that Apache Calcite Avatica Go 3.1.0-rc1 is available
> for voting. If you have a chance, please try to run the tests, verify
> the signature and vote. Your vote will be extremely useful to determine
> if this release candidate is suitable to release.
>
> Francis
>
> On 31/08/2018 10:35 AM, Francis Chuang wrote:
> > Hi all,
> >
> > I have created a release for Apache Calcite Avatica Go 3.1.0, release
> > candidate 1.
> >
> > The release notes are available here:
> > https://github.com/apache/calcite-avatica-go/blob/master/site/_docs/go_history.md
> >
> > The commit to be voted on:
> > http://git-wip-us.apache.org/repos/asf/calcite-avatica-go/commit/f564cfa42948b9a5c4c7f98f3e43ab5971bcaeda
> >
> > The hash is f564cfa42948b9a5c4c7f98f3e43ab5971bcaeda
> >
> > The artifacts to be voted on are located here:
> > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-go-3.1.0-rc1/
> >
> > The hashes of the artifacts are as follows:
> >
> > src.tar.gz.sha256 64BC4D9D 197457DC B0573F12 4A75A298 CB5207D6 FDC14DCB 675FF731 0555F5A3
> >
> > Release artifacts are signed with the following key:
> > https://people.apache.org/keys/committer/francischuang.asc
> >
> > Instructions for running the test suite is located here:
> > https://github.com/apache/calcite-avatica-go/blob/master/site/develop/avatica-go.md#testing
> >
> > Please vote on releasing this package as Apache Calcite Avatica Go 3.1.0.
> >
> > To run the tests without a Go environment, install docker and docker-compose. Then, in the root of the release's directory, run:
> > docker-compose up --build
> >
> > The vote is open for the next 72 hours and passes if a majority of
> > at least three +1 PMC votes are cast.
> >
> > [ ] +1 Release this package as Apache Calcite Avatica Go 3.0.0
> > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > [ ] -1 Do not release this package because...
> >
> >
> > Here is my vote:
> >
> > +1 (binding)
> >
> > Francis
> >
>