You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/14 19:20:41 UTC
[GitHub] [arrow] save-buffer commented on a diff in pull request #12872: ARROW-16166: [C++][Compute] Utilities for assembling join output
save-buffer commented on code in PR #12872:
URL: https://github.com/apache/arrow/pull/12872#discussion_r850736637
##########
cpp/src/arrow/compute/light_array_test.cc:
##########
@@ -0,0 +1,504 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "arrow/compute/light_array.h"
+
+#include <gtest/gtest.h>
+
+#include "arrow/compute/exec/test_util.h"
+#include "arrow/testing/generator.h"
+#include "arrow/testing/gtest_util.h"
+#include "arrow/type.h"
+
+namespace arrow {
+namespace compute {
+
+const std::vector<std::shared_ptr<DataType>> kSampleFixedDataTypes = {
+ int8(), int16(), int32(), int64(), uint8(),
+ uint16(), uint32(), uint64(), decimal128(38, 6), decimal256(76, 6)};
+const std::vector<std::shared_ptr<DataType>> kSampleBinaryTypes = {
+ utf8(), binary() /*, large_utf8(), large_binary()*/};
+
+TEST(KeyColumnMetadata, FromDataType) {
+ KeyColumnMetadata metadata = ColumnMetadataFromDataType(boolean());
+ ASSERT_EQ(0, metadata.fixed_length);
+ ASSERT_EQ(true, metadata.is_fixed_length);
+ ASSERT_EQ(false, metadata.is_null_type);
+
+ metadata = ColumnMetadataFromDataType(null());
+ ASSERT_EQ(true, metadata.is_null_type);
+
+ for (const auto& type : kSampleFixedDataTypes) {
+ int byte_width =
+ internal::checked_pointer_cast<FixedWidthType>(type)->bit_width() / 8;
+ metadata = ColumnMetadataFromDataType(type);
+ ASSERT_EQ(byte_width, metadata.fixed_length);
+ ASSERT_EQ(true, metadata.is_fixed_length);
+ ASSERT_EQ(false, metadata.is_null_type);
+ }
+
+ for (const auto& type : {binary(), utf8()}) {
+ metadata = ColumnMetadataFromDataType(type);
+ ASSERT_EQ(4, metadata.fixed_length);
+ ASSERT_EQ(false, metadata.is_fixed_length);
+ ASSERT_EQ(false, metadata.is_null_type);
+ }
+
+ for (const auto& type : {large_binary(), large_utf8()}) {
+ metadata = ColumnMetadataFromDataType(type);
+ ASSERT_EQ(8, metadata.fixed_length);
+ ASSERT_EQ(false, metadata.is_fixed_length);
+ ASSERT_EQ(false, metadata.is_null_type);
+ }
+}
+
+TEST(KeyColumnArray, FromArrayData) {
+ for (const auto& type : kSampleFixedDataTypes) {
+ ARROW_SCOPED_TRACE("Type: ", type->ToString());
+ // `array_offset` is the offset of the source array (e.g. if we are given a sliced
+ // source array) while `offset` is the offset we pass when constructing the
+ // KeyColumnArray
+ for (auto array_offset : {0, 1}) {
+ ARROW_SCOPED_TRACE("Array offset: ", array_offset);
+ for (auto offset : {0, 1}) {
+ ARROW_SCOPED_TRACE("Constructor offset: ", offset);
+ std::shared_ptr<Array> array;
+ int byte_width =
+ internal::checked_pointer_cast<FixedWidthType>(type)->bit_width() / 8;
+ if (is_decimal(type->id())) {
+ array = ArrayFromJSON(type, R"(["1.123123", "2.123123", null])");
+ } else {
+ array = ArrayFromJSON(type, "[1, 2, null]");
+ }
+ array = array->Slice(array_offset);
+ int length = static_cast<int32_t>(array->length()) - offset - array_offset;
+ int buffer_offset_bytes = (offset + array_offset) * byte_width;
+ KeyColumnArray kc_array = ColumnArrayFromArrayData(array->data(), offset, length);
+ // Maximum tested offset is < 8 so validity is just bit offset
+ ASSERT_EQ(offset + array_offset, kc_array.bit_offset(0));
+ ASSERT_EQ(0, kc_array.bit_offset(1));
+ ASSERT_EQ(array->data()->buffers[0]->data(), kc_array.data(0));
+ ASSERT_EQ(array->data()->buffers[1]->data() + buffer_offset_bytes,
+ kc_array.data(1));
+ ASSERT_EQ(nullptr, kc_array.data(2));
+ ASSERT_EQ(length, kc_array.length());
+ // When creating from ArrayData always create read-only
+ ASSERT_EQ(nullptr, kc_array.mutable_data(0));
+ ASSERT_EQ(nullptr, kc_array.mutable_data(1));
+ ASSERT_EQ(nullptr, kc_array.mutable_data(2));
+ }
+ }
+ }
+}
+
+TEST(KeyColumnArray, FromArrayDataBinary) {
+ for (const auto& type : kSampleBinaryTypes) {
+ ARROW_SCOPED_TRACE("Type: ", type->ToString());
+ for (auto array_offset : {0, 1}) {
+ ARROW_SCOPED_TRACE("Array offset: ", array_offset);
+ for (auto offset : {0, 1}) {
+ ARROW_SCOPED_TRACE("Constructor offset: ", offset);
+ std::shared_ptr<Array> array = ArrayFromJSON(type, R"(["xyz", "abcabc", null])");
+ int offsets_width =
+ static_cast<int>(internal::checked_pointer_cast<BaseBinaryType>(type)
+ ->layout()
+ .buffers[1]
+ .byte_width);
+ array = array->Slice(array_offset);
+ int length = static_cast<int32_t>(array->length()) - offset - array_offset;
+ int buffer_offset_bytes = (offset + array_offset) * offsets_width;
+ KeyColumnArray kc_array = ColumnArrayFromArrayData(array->data(), offset, length);
+ ASSERT_EQ(offset + array_offset, kc_array.bit_offset(0));
+ ASSERT_EQ(0, kc_array.bit_offset(1));
+ ASSERT_EQ(array->data()->buffers[0]->data(), kc_array.data(0));
+ ASSERT_EQ(array->data()->buffers[1]->data() + buffer_offset_bytes,
+ kc_array.data(1));
+ ASSERT_EQ(array->data()->buffers[2]->data(), kc_array.data(2));
+ ASSERT_EQ(length, kc_array.length());
+ // When creating from ArrayData always create read-only
+ ASSERT_EQ(nullptr, kc_array.mutable_data(0));
+ ASSERT_EQ(nullptr, kc_array.mutable_data(1));
+ ASSERT_EQ(nullptr, kc_array.mutable_data(2));
+ }
+ }
+ }
+}
+
+TEST(KeyColumnArray, FromArrayDataBool) {
+ for (auto array_offset : {0, 1}) {
+ ARROW_SCOPED_TRACE("Array offset: ", array_offset);
+ for (auto offset : {0, 1}) {
+ ARROW_SCOPED_TRACE("Constructor offset: ", offset);
+ std::shared_ptr<Array> array = ArrayFromJSON(boolean(), "[true, false, null]");
+ array = array->Slice(array_offset);
+ int length = static_cast<int32_t>(array->length()) - offset - array_offset;
+ KeyColumnArray kc_array = ColumnArrayFromArrayData(array->data(), offset, length);
+ ASSERT_EQ(offset + array_offset, kc_array.bit_offset(0));
+ ASSERT_EQ(offset + array_offset, kc_array.bit_offset(1));
+ ASSERT_EQ(array->data()->buffers[0]->data(), kc_array.data(0));
+ ASSERT_EQ(array->data()->buffers[1]->data(), kc_array.data(1));
+ ASSERT_EQ(length, kc_array.length());
+ ASSERT_EQ(nullptr, kc_array.mutable_data(0));
+ ASSERT_EQ(nullptr, kc_array.mutable_data(1));
+ }
+ }
+}
+
+// TEST(KeyColumnArray, FromArrayDataNull) {
Review Comment:
remove or uncomment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org