You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/10/02 11:19:18 UTC

[GitHub] [incubator-seatunnel] TyrantLucifer opened a new pull request, #2971: [Improve][Connector-V2] Improve text write

TyrantLucifer opened a new pull request, #2971:
URL: https://github.com/apache/incubator-seatunnel/pull/2971

   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
   
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   -->
   
   ## Purpose of this pull request
   
   close #2970
   
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
   
   ## Check list
   
   * [x] Code changed are covered with tests, or it does not need tests for reason:
   * [ ] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #2971: [Improve][Connector-V2] Improve text write

Posted by GitBox <gi...@apache.org>.
hailin0 commented on code in PR #2971:
URL: https://github.com/apache/incubator-seatunnel/pull/2971#discussion_r990791794


##########
seatunnel-e2e/seatunnel-spark-connector-v2-e2e/connector-file-spark-e2e/src/test/resources/file/fakesource_to_local_text.conf:
##########
@@ -54,12 +82,8 @@ sink {
     path="/tmp/test/text"
     field_delimiter="\t"
     row_delimiter="\n"
-    partition_by=["age"]
-    partition_dir_expression="${k0}=${v0}"
-    is_partition_field_write_in_file=true

Review Comment:
   ok, maybe there can be dedicated partition testcase



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #2971: [Improve][Connector-V2] Improve text write

Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on PR #2971:
URL: https://github.com/apache/incubator-seatunnel/pull/2971#issuecomment-1269615696

   > Please add UT/IT for this pr.
   
   Done, pls review again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #2971: [Improve][Connector-V2] Improve text write

Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on code in PR #2971:
URL: https://github.com/apache/incubator-seatunnel/pull/2971#discussion_r990792157


##########
seatunnel-e2e/seatunnel-spark-connector-v2-e2e/connector-file-spark-e2e/src/test/resources/file/fakesource_to_local_text.conf:
##########
@@ -54,12 +82,8 @@ sink {
     path="/tmp/test/text"
     field_delimiter="\t"
     row_delimiter="\n"
-    partition_by=["age"]
-    partition_dir_expression="${k0}=${v0}"
-    is_partition_field_write_in_file=true

Review Comment:
   Yup, I will add more test cases in next pull requests until the connector is stable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #2971: [Improve][Connector-V2] Improve text write

Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on PR #2971:
URL: https://github.com/apache/incubator-seatunnel/pull/2971#issuecomment-1265260291

   > This is the same thing as #2976, Can you close this PR?
   
   #2976 is optimized for reading text files, this pr is optimized for writing text files.
   
   These two pr all dependent on text schema optimizing #2969


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #2971: [Improve][Connector-V2] Improve text write

Posted by GitBox <gi...@apache.org>.
hailin0 commented on code in PR #2971:
URL: https://github.com/apache/incubator-seatunnel/pull/2971#discussion_r990787116


##########
seatunnel-e2e/seatunnel-spark-connector-v2-e2e/connector-file-spark-e2e/src/test/resources/file/fakesource_to_local_text.conf:
##########
@@ -54,12 +82,8 @@ sink {
     path="/tmp/test/text"
     field_delimiter="\t"
     row_delimiter="\n"
-    partition_by=["age"]
-    partition_dir_expression="${k0}=${v0}"
-    is_partition_field_write_in_file=true

Review Comment:
   Use update instead of remove?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #2971: [Improve][Connector-V2] Improve text write

Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on code in PR #2971:
URL: https://github.com/apache/incubator-seatunnel/pull/2971#discussion_r990787875


##########
seatunnel-e2e/seatunnel-spark-connector-v2-e2e/connector-file-spark-e2e/src/test/resources/file/fakesource_to_local_text.conf:
##########
@@ -54,12 +82,8 @@ sink {
     path="/tmp/test/text"
     field_delimiter="\t"
     row_delimiter="\n"
-    partition_by=["age"]
-    partition_dir_expression="${k0}=${v0}"
-    is_partition_field_write_in_file=true

Review Comment:
   These parameters are not applicable in this scenario. So I removed those. The core of the test is full type writing. What do you think about it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Hisoka-X merged pull request #2971: [Improve][Connector-V2] Improve text write

Posted by GitBox <gi...@apache.org>.
Hisoka-X merged PR #2971:
URL: https://github.com/apache/incubator-seatunnel/pull/2971


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org