You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/03/24 18:44:27 UTC
[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #736: PHOENIX-5698 Phoenix Query with RVC IN list expression generates wron…
ChinmaySKulkarni commented on a change in pull request #736: PHOENIX-5698 Phoenix Query with RVC IN list expression generates wron…
URL: https://github.com/apache/phoenix/pull/736#discussion_r397363979
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/expression/InListExpression.java
##########
@@ -330,4 +342,98 @@ public String toString() {
public InListExpression clone(List<Expression> l) {
return new InListExpression(l, this.rowKeyOrderOptimizable);
}
+
+ public static List<InListColumnKeyValuePair> getSortedInListColumnKeyValuePair(List<Expression> children,
Review comment:
nit: Add comment header to method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services