You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/02 04:28:17 UTC
[GitHub] [kafka] showuon opened a new pull request #8774: KAFKA-10081: Remove an unused local variable to pass spotbugsMain check
showuon opened a new pull request #8774:
URL: https://github.com/apache/kafka/pull/8774
Investigate why the spotbugs failed, and find that there's a warning to an unused local variable.
> Dead store to isFreshAssignment in org.apache.kafka.clients.consumer.internals.AbstractStickyAssignor.generalAssign(Map, Map)
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax removed a comment on pull request #8774: KAFKA-10081: Remove an unused local variable to pass spotbugsMain check
Posted by GitBox <gi...@apache.org>.
mjsax removed a comment on pull request #8774:
URL: https://github.com/apache/kafka/pull/8774#issuecomment-637655696
Retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on pull request #8774: KAFKA-10081: Remove an unused local variable to pass spotbugsMain check
Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #8774:
URL: https://github.com/apache/kafka/pull/8774#issuecomment-637291533
Retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #8774: KAFKA-10081: Remove an unused local variable to pass spotbugsMain check
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #8774:
URL: https://github.com/apache/kafka/pull/8774#issuecomment-637264975
@mjsax @ableegoldman @abbccdda , could you review this PR since it keeps breaking the recent builds.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on pull request #8774: KAFKA-10081: Remove an unused local variable to pass spotbugsMain check
Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #8774:
URL: https://github.com/apache/kafka/pull/8774#issuecomment-637855089
Thanks for pointing out. This PR was opened first though :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #8774: KAFKA-10081: Remove an unused local variable to pass spotbugsMain check
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #8774:
URL: https://github.com/apache/kafka/pull/8774#issuecomment-637570083
```testReassignmentWithRandomSubscriptionsAndChanges``` is traced by #8778
```testMultiConsumerStickyAssignment``` is traced by #8777
+1 to merge this hotfix :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax merged pull request #8774: KAFKA-10081: Remove an unused local variable to pass spotbugsMain check
Posted by GitBox <gi...@apache.org>.
mjsax merged pull request #8774:
URL: https://github.com/apache/kafka/pull/8774
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on pull request #8774: KAFKA-10081: Remove an unused local variable to pass spotbugsMain check
Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #8774:
URL: https://github.com/apache/kafka/pull/8774#issuecomment-637655627
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #8774: KAFKA-10081: Remove an unused local variable to pass spotbugsMain check
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #8774:
URL: https://github.com/apache/kafka/pull/8774#issuecomment-637844195
Btw, this had already been fixed by https://github.com/apache/kafka/commit/a3d79ff23643d83f9df191522c003fb6335ca80c .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org