[GitHub] [royale-compiler] aharui commented on a change in pull request #150: update reproducible configuration to match current practice

[GitBox <gi...@apache.org>]

aharui commented on a change in pull request #150:
URL: https://github.com/apache/royale-compiler/pull/150#discussion_r429604955



##########
File path: pom.xml
##########
@@ -64,6 +64,7 @@
     <maven.wagon.http.retryHandler.class>standard</maven.wagon.http.retryHandler.class>
     <!-- Try at most 6 times to deploy every artifact -->
     <maven.wagon.http.retryHandler.count>6</maven.wagon.http.retryHandler.count>
+    <project.build.outputTimestamp>2020-05-17T18:04:00Z</project.build.outputTimestamp>

Review comment:
       AIUI, one of the goals of using the theoryinpractice plugin was to have the timestamp autogenerated.  
   
   Before that, we had a variable so the RM could choose a timestamp helps identify the release (using 9:07 for 0.9.7).
   
   What are the advantages of explicitly setting the timestamp in this change?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org